Skip to content

Commit

Permalink
Merge pull request #31 from ctrox/improve-failed-scaledown
Browse files Browse the repository at this point in the history
fix: improve handling on scaledown failure
  • Loading branch information
ctrox authored Sep 29, 2024
2 parents 3f82005 + 224ba73 commit 5641ce4
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions zeropod/container.go
Original file line number Diff line number Diff line change
Expand Up @@ -138,10 +138,10 @@ func (c *Container) scheduleScaleDownIn(in time.Duration) error {
log.G(c.context).Info("scaling down after scale down duration is up")

if err := c.scaleDown(c.context); err != nil {
// checkpointing failed, this is currently unrecoverable, so we
// shutdown our shim and let containerd recreate it.
log.G(c.context).Fatalf("scale down failed: %s", err)
os.Exit(1)
// checkpointing failed, this is currently unrecoverable. We set our
// initialProcess as exited to make sure it's restarted
log.G(c.context).Errorf("scale down failed: %s", err)
c.initialProcess.SetExited(1)
}

})
Expand Down

0 comments on commit 5641ce4

Please sign in to comment.