Add nansum and nanmean functions
#308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomwhite
commented
Sep 13, 2023
| if ( | ||
| any(s > 1 for i, s in enumerate(result.chunksize) if i in axis) | ||
| or func != combine_func | ||
| ): |
There was a problem hiding this comment.
This condition needs to be removed since otherwise there are cases where no function is ever run in reduction. In particular if the array is of size 1 along the reduction axis. So far this hasn't been a problem since the reduction of a single element has always been that element (e.g. sum(1) is 1). But that doesn't hold for NaN (e.g. nansum(nan) is 0).
….array_api` since they are not yet standard)
Now moved |
|
Looks like we might be hitting fsspec/filesystem_spec#1357 (which f284639 fixes by excluding the relevant fsspec release). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for #153 (although the Xarray side would need work too). I put the new functions in
cubed.array, but there is a strong argument to put them (and all the existing array API functions) in the top-levelcubednamespace (see #307).