Update Coiled example #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Good idea - looks like we could tell it to scale at each node of the plan pretty easily at least. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried running the Coiled example today and found that it needed some updates.
The name of
coiled.runhas changed tocoiled.function, and some of the parameters have changed. This PR fixes that, and makes a few other simplifications/changes.Also, I noticed that the scaling up when running a bigger example (
coiled-add-random.py) wasn't what I expected - it scaled first to 3 then later to 6 instances. The 3 was probably because there were 3 tasks in the first stage. The second stage had 100 tasks.I wonder if we could adpaptively scale to the maximum number of tasks for any stage of a plan before starting the computation? (Or maybe a fraction of that number.)