Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tree merge chunks #527

Closed
wants to merge 2 commits into from
Closed

Tree merge chunks #527

wants to merge 2 commits into from

Conversation

tomwhite
Copy link
Member

See #277

@tomwhite tomwhite added the core label Jul 30, 2024
@dcherian
Copy link

dcherian commented Jul 30, 2024 •
edited
Loading

Shouldn't this be the algorithm in to merge_chunks for merging to an intermediate chunking? I don't see why we'd want to restrict it to just condensing to one chunk along an axis.

@tomwhite
Copy link
Member Author

tomwhite commented Aug 1, 2024

Shouldn't this be the algorithm in to merge_chunks for merging to an intermediate chunking? I don't see why we'd want to restrict it to just condensing to one chunk along an axis.

You're right!

I'm going to close this for now as it's not needed for #531

@tomwhite tomwhite closed this Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomwhite @dcherian