Adding Scoreboard command to the info.lua

[tonitch]

Implementing /scoreboard as part of the #158
info.lua updated for an overview of the work to do

[tonitch]

I just noticed that my ide removed all the indentation. I don't know if this is a problem

[12xx12]

Hi and welcome to the project.

About the whitespace:
The change itself is not that bad. But to keep this PR clean, pls move it to a new PR

[tonitch]

This is basically it for the command, I will add Comments and more comprehensive error message then It will be good to merge I think

[bearbin]

I'll review this tomorrow in depth. It looks good generally, but the documentation messages could do with some standardisation, and the commands could do with some changes to correspond better to the vanilla ones.

[tonitch]

I used this as reference for the commands, I tried to be as accurate as possible with the commands but there was not the outputs of the commands so I made it a bit like I though

I will launch a minecraft world to test and documents the outputs more accurately, I just have no time this w-e, I will try to do this next week

[tonitch]

I want to make sure the code is clean and follow the project's structure so I checked other files as cmd_effect.lua for instance.

But I don't understand, Why does the Response Variable is returned as this doesn't seem to be handle by cuberite but also, why should I return the content of cPlayer:sendMessage to Response as this function doesn't seems to return anything...

[mathiascode]

Why does the Response Variable is returned as this doesn't seem to be handle by cuberite

It's used for the console command to print the response:

Core/cmd_effect.lua

Lines 67 to 69 in baf6a4e

	function HandleConsoleEffect(Split)
	return HandleEffectCommand(Split)
	end

but also, why should I return the content of cPlayer:sendMessage to Response as this function doesn't seems to return anything...

There are additional functions that return the message when appropriate:

Core/core_functions.lua

Lines 72 to 97 in baf6a4e

	-- If the target is a player, the SendMessage function takes care of sending the message to the player.
	-- If the target is a command block or the console, the message is simply returned to the calling function,
	-- which delivers it appropriately
	function SendMessage(Player, Message)
	if Player then
	Player:SendMessageInfo(Message)
	return nil
	end
	return Message
	end
	function SendMessageSuccess(Player, Message)
	if Player then
	Player:SendMessageSuccess(Message)
	return nil
	end
	return Message
	end
	function SendMessageFailure(Player, Message)
	if Player then
	Player:SendMessageFailure(Message)
	return nil
	end
	return Message
	end

[tonitch]

I am currently implementing the console side of the command but I have a problem... scoreboard by cuberite work as a per world basis. so when a player execute a scoreboard command I usually get the player's world to create the scoreboard... but when the console does it. what should I do?

[tonitch]

I was wondering... is there a better way to send the result of a command (with multiple line) than doing it with LOG() ?

[mathiascode]

This is how the /tps command does it:

Core/cmd_tps.lua

Lines 34 to 42 in baf6a4e

	function HandleTpsCommand(Split, Player)
	local Response = {}
	table.insert(Response, "Global TPS: " .. GetAverageNum(GlobalTps))
	for WorldName, WorldTps in pairs(TpsCache) do
	table.insert(Response, "World \"" .. WorldName .. "\": " .. GetAverageNum(WorldTps) .. " TPS")
	end
	return true, SendMessage(Player, table.concat(Response, "\n"))
	end

I don't remember if we have other commands in the new format that output multiple lines.

Edit: another one
https://github.com/cuberite/Core/blob/master/cmd_players.lua

[tonitch]

I think I'm quite done ?!

[mathiascode]

Use PascalCase in general.

[tonitch]

There we go, Ready again!

[tonitch]

all done

[mathiascode]

@tonitch Could you create a follow-up PR addressing some unhandled exceptions when invalid command arguments are provided?