Reconciliation workers #421
Conversation
felipao-mx
commented
Oct 26, 2023
•
felipao-mx
commented
- add tasks to get deposits status
- add validation to send_order task to retry transfers that are stuck
Codecov Report
@@ Coverage Diff @@
## master #421 +/- ##
==========================================
+ Coverage 99.62% 99.64% +0.01%
==========================================
Files 26 27 +1
Lines 1081 1133 +52
Branches 98 107 +9
==========================================
+ Hits 1077 1129 +52
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
speid/tasks/transactions.py
Outdated
| def check_deposits_status(deposit: Dict) -> None: | ||
| req = DepositStatusQuery(**deposit) | ||
| try: | ||
| transaction = Transaction.objects.get( |
There was a problem hiding this comment.
Podría ser que tenga multiples resultados, manejar esa excepción también, es poco probable pero puede suceder
speid/models/transaction.py
Outdated
| self.speid_id, | ||
| f'Can not retrieve transaction stp_id: {self.stp_id}', | ||
| ) | ||
| elif not self.stp_id and not status: |
There was a problem hiding this comment.
Podría darse el caso de realizar una devolución a una txn aplicada, me parece mejor para este caso lanzar la excepción TransactionNeedManualReviewError
