Skip to content

Commit

Permalink
test(docs-e2e): disable flaky instagram link interaction
Browse files Browse the repository at this point in the history
  • Loading branch information
MFarabi619 committed Dec 3, 2024
1 parent 61d7197 commit 3a7b220
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 10 deletions.
12 changes: 6 additions & 6 deletions .github/workflows/TEST_E2E.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,22 +23,22 @@ jobs:
- name: Fetch main branch
run: git fetch origin main # Explicitly fetch the 'main' branch to ensure it's available

- name: 📦 Install pnpm
uses: pnpm/action-setup@v4
with:
run_install: true

- name: Install Node.js
uses: actions/setup-node@v4
with:
node-version: 20
cache: pnpm

- name: 📦 Install pnpm
uses: pnpm/action-setup@v4
with:
run_install: true

- name: 🎭 Install Playwright Browsers
run: pnpm playwright install --with-deps

# - name: ⚗️ Run E2E Tests for Affected Projects
# run: pnpm nx affected -t e2e --parallel=2 --base=origin/main --head=HEAD --verbose
# run: pnpm nx affected -t e2e --parallel=2 --reporter=html --base=origin/main --head=HEAD --verbose

- name: 💀 Run Docs E2E Tests
run: pnpm nx e2e docs-e2e --reporter=html --verbose
Expand Down
4 changes: 4 additions & 0 deletions apps/docs-e2e/playwright.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -49,14 +49,17 @@ export default defineConfig({
{
name: 'firefox (desktop)',
use: { ...devices['Desktop Firefox'] },
testIgnore: ['./src/lighthouse.spec.ts'],
},
{
name: 'webkit (desktop)',
use: { ...devices['Desktop Safari'] },
testIgnore: ['./src/lighthouse.spec.ts'],
},
{
name: 'webkit (tablet)',
use: { ...devices['iPad Mini'] },
testIgnore: ['./src/lighthouse.spec.ts'],
},
{
name: 'chromium (mobile)',
Expand All @@ -65,6 +68,7 @@ export default defineConfig({
{
name: 'webkit (mobile)',
use: { ...devices['iPhone 12'] },
testIgnore: ['./src/lighthouse.spec.ts'],
},
],
// Ignore Chromium projects in CI to speed up runs
Expand Down
10 changes: 6 additions & 4 deletions apps/docs-e2e/src/docs.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ const CUHACKING_2025_PORTAL_URL = 'https://portal.cuhacking.ca/'
// const CUHACKING_2025_ESLINT_URL = 'https://eslint.cuhacking.ca/rules'

const CUHACKING_2025_DISCORD_URL = 'https://discord.com/invite/h2cQqF9aZf'
const CUHACKING_2025_INSTAGRAM_URL = 'https://www.instagram.com/cuhacking/'
// const CUHACKING_2025_INSTAGRAM_URL = 'https://www.instagram.com/cuhacking/'

// TODO: Uncomment when the link works - see test below
// const CUHACKING_2025_LINKED_IN_URL = 'https://www.linkedin.com/company/cuhacking/'
Expand Down Expand Up @@ -131,9 +131,11 @@ test.describe('Common MOBILE, TABLET and DESKTOP Links', {
await expect(docsLayoutPage.instagramLink).toBeVisible()
})

test('should take user to Instagram when Instagram link clicked', async ({ docsLayoutPage }) => {
await clickAndGoToPage(docsLayoutPage, docsLayoutPage.instagramLink, CUHACKING_2025_INSTAGRAM_URL)
})
// TODO: Instagram link requires auth to view

// test('should take user to Instagram when Instagram link clicked', async ({ docsLayoutPage }) => {
// await clickAndGoToPage(docsLayoutPage, docsLayoutPage.instagramLink, CUHACKING_2025_INSTAGRAM_URL)
// })

test('should contain LinkedIn link', async ({ docsLayoutPage }) => {
await expect(docsLayoutPage.linkedinLink).toBeVisible()
Expand Down

0 comments on commit 3a7b220

Please sign in to comment.