Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): add cuhacking google calendar #192

Merged
merged 1 commit into from
Dec 15, 2024
Merged

feat(docs): add cuhacking google calendar #192

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions apps/docs/content/docs/index.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ Planning, conventions, and references for our custom meta-framework that powers

It's also written in a beginner-friendly language in order to provide a smooth onboarding experience for external contributors, and act as a general open-source reference for other projects.


## Our Priorities

<div className="grid grid-cols-1 md:grid-cols-2 lg:grid-cols-4 relative py-10 mx-auto">
Expand Down Expand Up @@ -281,6 +282,17 @@ We follow the [Extreme Programming](https://en.wikipedia.org/wiki/Extreme_progra
/>
</Cards>

## Calendar

<iframe
className="mt-4 w-full h-[600px] rounded-lg bg-black"
src="https://calendar.google.com/calendar/embed?height=600&wkst=1&ctz=America%2FToronto&showPrint=0&mode=WEEK&src=ZmNkYmEzZjM1NGQ0ZTAxNTUyZTI0OTVkNzQzMTA1YmQ5ZWZjZTRlMTA3NmNkYTNjMWVjMTQ1NGQwZjVmYWE3M0Bncm91cC5jYWxlbmRhci5nb29nbGUuY29t&color=%237CB342"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Calendar ID should be managed as a configuration variable

The calendar is embedded in the documentation site and appears to be used for displaying team schedules and events. Based on the context:

  1. The calendar ID is only used in this single location (index.mdx)
  2. It's part of the public documentation, suggesting the calendar is intentionally public-facing
  3. However, the calendar ID should be managed as a configuration variable to:
    • Make it easier to update across environments
    • Follow security best practices by not hardcoding sensitive identifiers
    • Enable different calendars for different deployments (staging/production)

Recommendations:

  • Move the calendar ID to an environment variable
  • Update the iframe src to use the environment variable
  • Document the calendar's public visibility requirement in the project documentation
🔗 Analysis chain

Verify calendar sharing settings and access control

Please verify that:

  1. The calendar is intentionally set to be publicly viewable
  2. The calendar ID in the URL is meant to be exposed in the public documentation

Consider using environment variables for the calendar ID if it needs to be configurable across different environments.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check if the calendar ID is used elsewhere in the codebase
# This helps determine if it's already being managed as a configuration

# Search for the calendar ID
rg "fcdbA3f354d4e01552e2495d743105bd9efce4e1076cda3c1ec1454d0f5faa73"

Length of output: 69

Script:

#!/bin/bash
# Let's check for any environment variables or configuration files that might contain calendar-related settings
rg -i "calendar" --type=yaml --type=env --type=json

# Also check for any Google Calendar related configurations or embeddings
rg -i "google.*calendar|calendar.*embed" -g '!*.md' -g '!*.mdx'

Length of output: 145

Script:

#!/bin/bash
# Let's check for any configuration files that might contain calendar settings
fd -e yaml -e yml -e json -x rg -i "calendar" {}

# Let's also check the specific file to see its context
cat "apps/docs/content/docs/index.mdx"

Length of output: 11975

styles="border-width:0"
frameborder="0"
scrolling="no"
allowFullScreen>
</iframe>

## Categories

<Cards>
Expand Down
Loading