-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(contribution-guidelines): update Nx version #72
Conversation
Reviewer's Guide by SourceryThis pull request updates the Nx version specified in the contribution guidelines documentation. The change ensures consistency in the Nx version used across the project. File-Level Changes
Tips
|
❌ Deploy Preview for cuhacking-docs failed.
|
❌ Deploy Preview for cuhacking-portal-dev failed. Why did it fail? →
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @JeremyFriesenGitHub - I've reviewed your changes - here's some feedback:
Overall Comments:
- There's a discrepancy between the PR description, which mentions updating to version 19.6.2, and the actual change in the diff, which shows version 19.5.7. Could you clarify which version is intended and update either the PR description or the code accordingly?
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Optional: Specify commit message scopes. So instead of |
Summary by Sourcery
Update the contribution guidelines to specify a fixed Nx version for installation, ensuring consistency in the development environment.
Documentation: