Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DACCESS-360 - simple search WIP #2192

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from
Draft

DACCESS-360 - simple search WIP #2192

wants to merge 2 commits into from

Conversation

chrisrlc
Copy link
Contributor

@chrisrlc chrisrlc commented Dec 4, 2024

In simple search:

In both simple and advanced search:

  • When search field is not defined in CatalogController (e.g. any search field not in simple or advanced search field dropdowns, or used in click-to-search fields like in browse info pages or catalog records), default to searching 'all_fields'.

TODO:

  • Check out CornellCatalog#index
  • Sync with Sarah/Matt to see if there could be other Folio/My Account/Requests/etc places that need search fields not used elsewhere in blacklight-cornell.
  • Should DISPLAY_SOLR_QUERY be in Jenkinsfile or in a .env file on jenkins?
  • Maybe consider moving code out of SearchBuilder into separate QueryBuilder object? Or wait until removing prefix operators from bento search, since then it'll be more necessary to have reusable logic outside SearchBuilder.

@chrisrlc chrisrlc force-pushed the DACCESS-360-simple branch 2 times, most recently from 229319e to c739368 Compare December 5, 2024 21:57
@chrisrlc chrisrlc changed the base branch from DACCESS-360 to dev December 5, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant