Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPS-5145 Change pipeline to PHP 7.4 and add tests to pipeline #194

Merged
merged 6 commits into from
Jul 17, 2024
Merged

UPS-5145 Change pipeline to PHP 7.4 and add tests to pipeline #194

merged 6 commits into from
Jul 17, 2024

Conversation

grubolsch
Copy link
Contributor

Changed

Upgraded to PHP 7.4

Ticket: https://jira.uitdatabank.be/browse/UPS-5145

@grubolsch grubolsch force-pushed the UPS-5145/upgrade-to-php-7.4 branch from 09244a4 to 1369553 Compare July 16, 2024 12:08
LucWollants
LucWollants requested changes Jul 16, 2024
View reviewed changes
Copy link

@LucWollants LucWollants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed through Slack no need to change the CI pipeline because phing runs the unit tests

@grubolsch
Copy link
Contributor Author

Processed feedback

@JonasVHG JonasVHG self-assigned this Jul 16, 2024
@grubolsch grubolsch merged commit ca7e1b8 into master Jul 17, 2024
1 check passed
@grubolsch grubolsch deleted the UPS-5145/upgrade-to-php-7.4 branch July 17, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonasVHG JonasVHG JonasVHG approved these changes

@LucWollants LucWollants LucWollants approved these changes

Assignees

@JonasVHG JonasVHG

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grubolsch @LucWollants @JonasVHG