Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CUTL-133] 🔄 (Login/Forgot Password/Register) Store email so that we can share it across pages #29

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[CUTL-133] 🔄 (Login/Forgot Password/Register) Store email so that we can share it across pages #29

wants to merge 2 commits into from

Conversation

mcgomez
Copy link
Member

@mcgomez mcgomez commented Feb 23, 2022 •
edited
Loading

Feature

  • Pass email from Login page to Register and PasswordResetRequest pages

Approach

  • Pass email through location.state
  • Set as the default email value within the forms

Resources

--

mcgomez
mcgomez commented Feb 23, 2022
View reviewed changes
app/pages/Login/Login.js Outdated Show resolved Hide resolved
@mcgomez mcgomez mentioned this pull request Feb 23, 2022
Closed
@mcgomez mcgomez force-pushed the feature/login-forgot-password-email branch from 7bfce4b to 633a813 Compare February 23, 2022 17:09
@mcgomez
[CUTL-140] 🔄 (Base) Update implementation for passing email field t…
eba0990 
…hrough various forms

- Clean up code a bit
- Switch out `Link`s for regular `Button`s so that we can pass refs through route state
- Add reference to the login email field so that we can pass the value through to the forgot password and sign up pages
@mcgomez
Copy link
Member Author

mcgomez commented Feb 23, 2022

@emilyemorehouse I updated the implementation within the Login page to support using refs to keep an uncontrolled form, but I couldn't mirror that implementation on the Register or PasswordResetRequest pages. Currently grommet doesn't totally support allowing uncontrolled forms and inputs within having default values. It technically works in terms of setting a default value, but validation and changes are not reflected within the form state. Reference: grommet/grommet#4328

@mcgomez mcgomez changed the title [CUTL-133] 🔄 (Login/Forgot Password) Store email so that we can share it across both pages [CUTL-133] 🔄 (Login/Forgot Password/Register) Store email so that we can share it across pages Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilyemorehouse emilyemorehouse Awaiting requested review from emilyemorehouse

Assignees
No one assigned
Labels
status:held
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcgomez @emilyemorehouse