Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding basic CI and fixing minor problems #17

Merged
merged 4 commits into from
Oct 18, 2023
Merged

Adding basic CI and fixing minor problems #17

merged 4 commits into from
Oct 18, 2023

Conversation

iago-suarez
Copy link
Collaborator

This PR contains integration tests that check that LG and GS keep working and also fix some minor bugs:

  • Integration tests checking the accuracy of homography estimation
  • Removing unused conf parameter from eval_matches_homography
  • Expecting all data to be batched/non-batched in eval_matches_homography, eval_homography_robust, eval_homography_dlt
  • Converting pose estimation evaluation to torch and fixing a bug in the return order!
  • Removing .cuda() in the lightglue_pretrained constructor

Please check the code and just let me know if you agree with these changes 😃

@iago-suarez iago-suarez requested a review from sarlinpe October 15, 2023 18:46
Create python-tests.yml
Adding ceres and eigen dependencies

Adding coverage

Adding parameterized

Fixing GPU torch problems

Avoiding explicit transfer of the model to CUDA

Adding tests for eval utils and standardizing the batched/non-batched behaviour (only tested with homographies)

Testing failures in pytest

Fixing dummy test

Removing MishaKav/pytest-coverage-comment

Fixing problems in MegaDepth evaluation

Fixing division by 0 and converting function to torch

Fixing lint errors

Fixing isort errors
tests/test_integration.py Outdated Show resolved Hide resolved
tests/test_integration.py Outdated Show resolved Hide resolved
tests/test_integration.py Outdated Show resolved Hide resolved
tests/test_integration.py Outdated Show resolved Hide resolved
tests/test_integration.py Show resolved Hide resolved
gluefactory/geometry/epipolar.py Outdated Show resolved Hide resolved
tests/test_integration.py Outdated Show resolved Hide resolved
tests/test_integration.py Outdated Show resolved Hide resolved
Copy link
Member

@sarlinpe sarlinpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one comment left, LGTM otherwise - thanks a lot!

@@ -0,0 +1,133 @@
import logging
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unused import

@iago-suarez iago-suarez merged commit aa77276 into cvg:main Oct 18, 2023
2 checks passed
@iago-suarez
Copy link
Collaborator Author

Thanks for the review Paul! It is very cool that we have automatic tests, I will sleep better now 😅

tompritch30 pushed a commit to tompritch30/glue-factory that referenced this pull request May 30, 2024
* Adding integration tests

Create python-tests.yml
Adding ceres and eigen dependencies

Adding coverage

Adding parameterized

Fixing GPU torch problems

Avoiding explicit transfer of the model to CUDA

Adding tests for eval utils and standardizing the batched/non-batched behaviour (only tested with homographies)

Testing failures in pytest

Fixing dummy test

Removing MishaKav/pytest-coverage-comment

Fixing problems in MegaDepth evaluation

Fixing division by 0 and converting function to torch

Fixing lint errors

Fixing isort errors

* Addressing PR comments

* Addressing second round of PR comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants