feat: add referencing string lookup

cwrc · Aug 14, 2019 · 6a00296 · 6a00296
1 parent fb741a2
commit 6a00296
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 5 deletions.
diff --git a/package.json b/package.json
@@ -31,7 +31,7 @@
     "test:chrome": "cross-env NODE_ENV=test browserify test/browser.js | browser-run -b chrome | node test/extract-coverage.js | faucet ",
     "generate-coverage": "nyc report --reporter=lcov",
     "check-coverage": "nyc check-coverage --statements 90 --branches 90 --functions 90 --lines 90",
-    "report-coverage": "cat ./.nyc_output/lcov.info | codecov",
+    "report-coverage": "cat ./.nyc_output/coverage.json | codecov",
     "travis-deploy-once": "travis-deploy-once"
   },
   "devDependencies": {

diff --git a/src/index.js b/src/index.js
@@ -63,6 +63,10 @@ function getTitleLookupURI(queryString) {
     return getEntitySourceURI(queryString, 'work')
 }
 
+function getRSLookupURI(queryString) {
+    return getEntitySourceURI(queryString, 'thing')
+}
+
 function callDBPedia(url, queryString, queryClass) {
 
     return fetchWithTimeout(url).then((parsedJSON)=>{
@@ -102,13 +106,19 @@ function findTitle(queryString) {
     return callDBPedia(getTitleLookupURI(queryString), queryString, 'work')
 }
 
+function findRS(queryString) {
+    return callDBPedia(getRSLookupURI(queryString), queryString, 'thing')
+}
+
 module.exports = {
     findPerson: findPerson,
     findPlace: findPlace,
     findOrganization: findOrganization,
     findTitle: findTitle,
+    findRS: findRS,
     getPersonLookupURI: getPersonLookupURI,
     getPlaceLookupURI: getPlaceLookupURI,
     getOrganizationLookupURI: getOrganizationLookupURI,
     getTitleLookupURI: getTitleLookupURI,
+    getRSLookupURI: getRSLookupURI
 }
diff --git a/test/browser.js b/test/browser.js
@@ -25,7 +25,8 @@ var clock;
     {uriBuilderFn: 'getPersonLookupURI', testFixture:resultsFixture},
     {uriBuilderFn: 'getPlaceLookupURI', testFixture:resultsFixture},
     {uriBuilderFn: 'getOrganizationLookupURI', testFixture:resultsFixture},
-    {uriBuilderFn: 'getTitleLookupURI', testFixture:resultsFixture}
+    {uriBuilderFn: 'getTitleLookupURI', testFixture:resultsFixture},
+    {uriBuilderFn: 'getRSLookupURI', testFixture:resultsFixture}
 ].forEach(entityLookup=> {
 
    let uriBuilderFn = dbpedia[entityLookup.uriBuilderFn];
@@ -65,14 +66,14 @@ function doObjectsHaveSameKeys(...objects){
 }
 
 test('lookup builders', (assert)=> {
-    assert.plan(4);
-    ['getPersonLookupURI', 'getPlaceLookupURI', 'getOrganizationLookupURI', 'getTitleLookupURI'].forEach(uriBuilderMethod => {
+    assert.plan(5);
+    ['getPersonLookupURI', 'getPlaceLookupURI', 'getOrganizationLookupURI', 'getTitleLookupURI', 'getRSLookupURI'].forEach(uriBuilderMethod => {
         assert.comment(uriBuilderMethod);
         assert.ok(dbpedia[uriBuilderMethod](queryString).includes(queryString), 'should contain the query string');
     });
 });
 
-['findPerson', 'findPlace', 'findOrganization', 'findTitle'].forEach((nameOfLookupFn)=> {
+['findPerson', 'findPlace', 'findOrganization', 'findTitle', 'findRS'].forEach((nameOfLookupFn)=> {
     test(nameOfLookupFn, async function(assert){
         let thisAssert = assert
        // thisAssert.plan(21);