Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Sanity Test for Ansible 2.16 version #205

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ramavenkataloya
Copy link

@ramavenkataloya ramavenkataloya commented Sep 24, 2024

Desired Outcome

The goal of this PR is to resolve issues with the sanity and unit tests for Ansible 2.16, ensuring that the tests are executed successfully.

Implemented Changes

  • Added the ignore-2.16.txt file to ignore files.
  • Included Ansible 2.16 with a compatible Python version in the workflow/ansible-test.yml.
  • Updated the assertions in the unit tests for the lookup plugin to be compatible with Python 3.12.
  • Updated the Python version to be compatible with the Ansible devel package.

Connected Issue/Story

Resolves #[relevant GitHub issue(s), e.g. 76]

CyberArk internal issue ID: [insert issue ID]

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: [insert issue ID]
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@ramavenkataloya ramavenkataloya requested a review from a team as a code owner September 24, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant