Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hw interface check #883

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Fix hw interface check #883

merged 2 commits into from
Jan 16, 2024

Conversation

omichel
Copy link
Member

@omichel omichel commented Jan 16, 2024

Backport of #882

Yadunund and others added 2 commits January 16, 2024 21:52
Signed-off-by: Yadunund <[email protected]>
Fix version check for hardware_interface
@Yadunund
Copy link
Member

Looks like build succeeded on Rolling (main and testing) but tests are failing. Unfortunately I'm not familiar enough with the codebase to make any changes to fix tests.

@omichel
Copy link
Member Author

omichel commented Jan 16, 2024

I re-ran the tests and main/rolling passed... Probably some random failure...

@omichel omichel merged commit 6038a45 into master Jan 16, 2024
6 of 7 checks passed
@omichel omichel deleted the fix_hw_interface_check branch January 16, 2024 15:34
@Yadunund
Copy link
Member

Thanks @omichel! Could you bloom a new release for Rolling whenever you get a chance next?

@omichel
Copy link
Member Author

omichel commented Jan 17, 2024

I don't have time for this right now, you can do it yourself and I will be happy to help if needed. The instructions are here.

@Yadunund
Copy link
Member

Hi @omichel would really appreciate your help with blooming the release. I'm not sure how the version increases work in this project. Further i won't be able to run bloom as I don't have the required access within ros2-gbp

@omichel
Copy link
Member Author

omichel commented Jan 29, 2024

I just proposed to add you here. Hopefully, this will be accepted and merged soon.
The version numbering is based on the Webots version.
The current version is version='2023.1.1', where '2023.1' matches with the Webots version, e.g., R2023b ('2023.0' means Webots R2023a) and the final '.1' means first release of the ROS 2 interface for Webots R2023b. Thus, if you want to make new release, the version should be increased to '2023.1.2' to mean it aims at Webots R2023a and is version 2.

Yadunund added a commit that referenced this pull request Feb 5, 2024
Signed-off-by: Yadunund <[email protected]>
Co-authored-by: Yadunund <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants