Fix Modal Export Tests #2660
Open
Fix Modal Export Tests #2660
+17
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the updates to fix the
thoughtspacereplication, these just needed to run the timers appropriately. We might be able to combine the sequential dispatches but I don't want to increase complexity until we confirm there aren't any timing issues.If we encounter any intermittent errors in these tests then we might need to run the timers forward between the calls to
dispatch.In addition to the main fix, this (1) uses data-testid instead of finding the element by text and (2) removes an extraneous space from a span that broke the tests.
Closes #2130