-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lint: Tell users that backslashes are no longer necessary after => & | #6459
Conversation
6f7c711
to
4f3f8f1
Compare
cylc/flow/scripts/lint.py
Outdated
'U017': { | ||
'short': ( | ||
'`&` and `|` are line continuations without `\\`' | ||
), | ||
FUNCTION: re.compile(r'[&|]\s*\\').findall | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be part of S014
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that they should in time be, but at the moment they will not work if you are using compat mode Cylc 8 and Cylc 7 in Para||el, so I think that they should be an upgrade until Cylc 7 is more dead than it currently is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"more dead" 😁
Co-authored-by: Ronnie Dutta <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One typo detected and a couple of small tweaks suggested.
(It may be a bit picky, but I'd say "=>" etc., imply line continuation rather than being line continuation).
Co-authored-by: Hilary James Oliver <[email protected]>
Edit: superseded by #6493
Closes #6456
Check List
CONTRIBUTING.md
and added my name as a Code Contributor.setup.cfg
(andconda-environment.yml
if present).