Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shinyMobile 2.0.0 blog post #55

Merged
merged 11 commits into from
May 27, 2024
Merged

shinyMobile 2.0.0 blog post #55

merged 11 commits into from
May 27, 2024

Conversation

DivadNojnarg
Copy link
Collaborator

TBD

@DivadNojnarg DivadNojnarg requested a review from MikeJohnPage May 14, 2024 06:02
@DivadNojnarg
Copy link
Collaborator Author

@MikeJohnPage Currently blocked by posit-dev/shinylive#131 to continue. Will move it to ready when this is fixed.

@github-actions GitHub Actions
Copy link

Summary

Status Count
🔍 Total 835
✅ Successful 796
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 38
❓ Unknown 0
🚫 Errors 1

Errors per input

Errors in docs/posts/2021-03-09-seasonal-1.8/index.html

@MikeJohnPage
Copy link
Collaborator

@DivadNojnarg just tag me in this chat whenever you want me to check it. Thanks!

@DivadNojnarg
Copy link
Collaborator Author

@MikeJohnPage If you ignore the TO DO elements for now (supposed to contain the shinylive demo apps, each code snippet will have a running demo), you can start to review the content in general. To test it, you'll have to install with pak::pkg:install("RinteRface/[email protected]") and pak::pkg_install("DivadNojnarg/brochure").

There will be follow up posts to provide more detailed views about specific elements.

@DivadNojnarg DivadNojnarg marked this pull request as ready for review May 27, 2024 12:28
MikeJohnPage
MikeJohnPage requested changes May 27, 2024
View reviewed changes
Copy link
Collaborator

@MikeJohnPage MikeJohnPage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I've left you a few grammatical corrections and suggestions.

posts/2024-05-13-shinyMobile-2.0.0/index.qmd Outdated Show resolved Hide resolved
posts/2024-05-13-shinyMobile-2.0.0/index.qmd Outdated Show resolved Hide resolved
posts/2024-05-13-shinyMobile-2.0.0/index.qmd

#### How does this work?

At the time of writting of this blog post, you must install a patched `{brochure}` version with `devtools::install_github("DivadNojnarg/brochure")`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: can users expect this to be changed in the near future? Should a message be put here that they won't have to always use a patched version?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have guarantees on that for now. That's why we left "experimental".

posts/2024-05-13-shinyMobile-2.0.0/index.qmd Outdated Show resolved Hide resolved
posts/2024-05-13-shinyMobile-2.0.0/index.qmd Outdated Show resolved Hide resolved
posts/2024-05-13-shinyMobile-2.0.0/index.qmd Outdated Show resolved Hide resolved
posts/2024-05-13-shinyMobile-2.0.0/index.qmd Outdated Show resolved Hide resolved
posts/2024-05-13-shinyMobile-2.0.0/index.qmd Show resolved Hide resolved
posts/2024-05-13-shinyMobile-2.0.0/index.qmd Outdated Show resolved Hide resolved
posts/2024-05-13-shinyMobile-2.0.0/index.qmd Show resolved Hide resolved
@DivadNojnarg DivadNojnarg merged commit 5620abe into main May 27, 2024
1 check passed
@DivadNojnarg DivadNojnarg deleted the shinyMobile-2.0.0 branch May 27, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeJohnPage MikeJohnPage MikeJohnPage requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DivadNojnarg @MikeJohnPage