Skip to content

Commit

Permalink
NEWS and CRAN comments [ci skip]
Browse files Browse the repository at this point in the history
  • Loading branch information
krlmlr committed Nov 2, 2023
1 parent fa925b0 commit 8753133
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 37 deletions.
26 changes: 5 additions & 21 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,29 +2,24 @@

# dm 1.0.8

## news

- Add link to issue.
- Add Jan as contributor.

## Bug fixes

- `copy_dm_to()` creates string columns of necessary lengths for MariaDB and SQL Server. This worked before for SQL Server in dm 1.0.5, now also works on MariaDB (#311, #2066, #2082).

## Features

- Explicitly fail on `compute(temporary = TRUE)`, which never worked correctly (#2059, #2103).

- Warn about DuckDB not supporting autoincrementing primary keys (#2099).

## Chore

- Turn off renovate automerge.
- Add assertion.
- Make `check_suggested()` a standalone (#2054).

## Documentation

- Tweak vignette for `compute(temporary = TRUE)`.

- Update documentation of `check_suggested()` (@olivroy, #2055).

## Performance
Expand All @@ -33,22 +28,11 @@

## Testing

- Add test for `copy_dm_to(table_names = )` (#2101).
Closes #250.
- Remove final step, requiring all checks to pass (#2119).
For Aviator.
- Add final step that collects all checks (#2113).
- Work around test failures for dbplyr 2.4.0.
- Remove most skips from tests (#2052).
- Add test for `copy_dm_to(table_names = )` (#250, #2101).

## Uncategorized
- Work around test failures for dbplyr 2.4.0.

- Merge pull request #2077 from cynkra/snapshot-main-rcc-full-config-os-ubuntu-20-04-r-release-test-src-test-mssql-covr-false-desc-SQL-Server-without-covr.
- Merge pull request #2073 from cynkra/snapshot-main-rcc-full-config-os-ubuntu-22-04-r-release-test-src-test-sqlite-covr-true-desc-SQLite-with-covr.
- Merge pull request #2076 from cynkra/snapshot-main-rcc-full-config-os-ubuntu-22-04-r-release-test-src-test-duckdb-covr-true-desc-DuckDB-with-covr.
- Merge pull request #2074 from cynkra/snapshot-main-rcc-full-config-os-ubuntu-22-04-r-release-test-src-test-mysql-maria-covr-true-desc-MySQL-with-covr.
- Merge pull request #2067 from cynkra/snapshot-main-rcc-smoke-null.
- Merge branch 'cran-1.0.7'.
- Remove most skips from tests (#2052).


# dm 1.0.7
Expand Down
16 changes: 0 additions & 16 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,17 +1 @@
dm 1.0.8

## Cran Repository Policy

- [x] Reviewed CRP last edited 2023-08-15.

## R CMD check results

- [x] Checked locally, R 4.3.1
- [ ] Checked on CI system, R 4.3.2
- [ ] Checked on win-builder, R devel

Check the boxes above after successful execution and remove this line. Then run `fledge::release()`.

## Current CRAN check results

- [x] Checked on 2023-11-02, no problems found.

0 comments on commit 8753133

Please sign in to comment.