Exclude information_schema tables from dm by default if schema = NULL
#1130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krlmlr
reviewed
Jun 20, 2022
| @@ -254,6 +254,13 @@ filter_dm_meta <- function(dm_meta, catalog = NULL, schema = NULL) { | |||
| table_constraints <- table_constraints %>% filter(table_schema %in% !!schema) | |||
| key_column_usage <- key_column_usage %>% filter(table_schema %in% !!schema) | |||
| constraint_column_usage <- constraint_column_usage %>% filter(table_schema %in% !!schema) | |||
| } else { | |||
| schemata <- schemata %>% filter(schema_name != "information_schema") | |||
There was a problem hiding this comment.
Do we need tolower() here and everywhere?
|
I'm sorry, I was confused. #1123 now uses only objects from the current database if |
|
Closing for now, I believe we want |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #366. Does not address case of MSSQL using
dbnameinstead of schema (yet), as I'm unfamiliar with how that differs.