Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update howto-dm-db.Rmd #1211

Merged
merged 6 commits into from
Sep 20, 2022
Merged

Update howto-dm-db.Rmd #1211

merged 6 commits into from
Sep 20, 2022

Conversation

andreranza
Copy link
Member

@andreranza andreranza commented Jul 7, 2022 •
edited
Loading

Closes #1212

Starting from version 0.3.0 primary and foreign keys are imported automatically also from MariaDB

andreranza added 2 commits July 7, 2022 12:09
@andreranza
Update howto-dm-db.Rmd
bcadd5a 
From version 0.3.0 primary and foreign keys are imported automatically also from MariaDB
@andreranza
Set learn_keys = FALSE
f5ecd2e 
Here we are acting as it would not be possible to learn keys automatically. So, we set `learn_keys = FALSE`, otherwise the message "Keys queried successfully" would show up in the rendered example on https://cynkra.github.io/dm/articles/howto-dm-db.html
krlmlr
krlmlr reviewed Jul 7, 2022
View reviewed changes
Copy link
Collaborator

@krlmlr krlmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I'm fine with the first change, but the rest seems ok as it is, because we have a learn_keys = FALSE example later on.

krlmlr
krlmlr reviewed Sep 19, 2022
View reviewed changes
vignettes/howto-dm-db.Rmd Outdated Show resolved Hide resolved
@krlmlr krlmlr merged commit 58449d5 into cynkra:main Sep 20, 2022
@krlmlr
Copy link
Collaborator

krlmlr commented Sep 20, 2022

Thanks!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@krlmlr krlmlr krlmlr left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update howto-dm-db.Rmd
2 participants
@andreranza @krlmlr