fix: pass naming pattern through to dm_learn_from_db() (#2213) #2214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current Aviator status
This pull request is currently open (not queued). How to mergeTo merge this PR, comment
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
owenjonesuob
force-pushed
the
b-pass-names-pattern-to-learn
branch
2 times, most recently
from
14afa3c to
192226a
Compare
krlmlr
force-pushed
the
b-pass-names-pattern-to-learn
branch
from
192226a to
a1119ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2213.
I had to move the "smart default" logic for
.namesup one level, fromget_src_tbl_names()intodm_from_con()- but I think that is a better place to keep it anyway, since that's where its behaviour is documented.I've also made sure
names_patternis used consistently as the "internal" name for this argument, wherever we see this "naming pattern" concept.