-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rust review #8
Draft
sneurlax
wants to merge
115
commits into
main
Choose a base branch
from
review
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Rust review #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Likho & Diego, feel free to change the license, as I understand it this is released as "open source", however lacking a license may prevent it from being used in certain projects.
imported as io
just make an issue about it instead
This reverts commit 04065a8.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
run_listener
's definitions, etc)Future work:
Changes to API must be mirrored in at least both
ios/Classes/FlutterLibepiccashPlugin.h
andios/Classes/SwiftFlutterLibepiccashPlugin.swift
https://docs.rs/ffi_helpers/latest/ffi_helpers/panic/fn.catch_panic.html and attempt to catch errors as in https://docs.rs/ffi_helpers/latest/ffi_helpers/panic/fn.recover_panic_message.html
as in https://docs.rs/ffi_helpers/latest/ffi_helpers/error_handling/index.html
returning the signature might be problematic because I'd think they'd expire--we'd need to make a new signature for the current epicbox server challenge. but maybe that isn't an issue if we just have the rust side do it all over, might be easy