-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docker): replace php:8.1-fpm-alpine image by php:8.1-fpm-bookworm: alpine doesn't support GLOB_BRACE #1360
base: master
Are you sure you want to change the base?
Conversation
@IrAlfred, why shouldn't we consider changing the PHP image we're using? The issue arises due to the minimalistic nature of the Alpine image, which omits certain features. While it does reduce the Docker image size, is it worth the development effort required to work around the missing extensions? |
I've thought about it for a while... I agree with switching the base image. Which image would you recommend we use ? |
wouldn't php:8.1-fpm-bookworm be the one to use? Same php version, but running on the most up-to-date debian. Same publisher as the alpine-based image in use now. |
Thank you @indridieinarsson for the suggestion! @IrAlfred please try this one and keep us informed of the outcome. |
Thank you @jacob-js , I work on it |
1ac9f16
to
395ddee
Compare
dd5b969
to
fa71c5d
Compare
Please review @jacob-js and @indridieinarsson |
@indridieinarsson, please share some feedback as soon as you can! |
@mercihabam @IrAlfred. Not really an insightful comment, but I did test the PR, and it works. Great job. |
…e doesn't support GLOB_BRACE
fa71c5d
to
d157a89
Compare
Replace php:8.1-fpm-alpine docker base image by php:8.1-fpm-bookworm
This merge request replaces the php:8.1-fpm-alpine image with php:8.1-fpm-bookworm in our Docker setup. The change addresses the challenges caused by the minimalistic nature of the Alpine-based image, which often lacks key features and extensions required for smooth development and runtime environments.