Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parquet_integration #122
Parquet_integration #122
Changes from 95 commits
d606e21
6a66fa8
7e766a5
abe71e9
7b9e1e0
cf6039e
847dae7
25557c2
5369033
98e673c
3194ce5
a321c09
0e84e68
fc27c3e
cee0029
d9e8185
0c07ad2
e1292dd
1b64786
848baad
6c414f3
a5af51c
7f26041
a34c99d
9016f01
62d4685
5a3ef5b
a7cb5a3
7efc190
0d2f585
d34ce21
a0a72c6
1dedbda
e67a239
2565b6c
c42dd91
e5193b9
8e45b21
e08cb83
406d164
b72dc1d
dd7d50e
c4f3de7
38a988d
cfad784
be5a24a
d2eec56
3226f95
92e0c85
adc98df
0cd216c
bfb56cb
a97b644
382c8ce
3e7c795
e7e089f
0d19431
d96303f
d553b38
df2eba3
51cb5f6
309ab0d
e166bf9
c987cf5
6ed7b8c
5f9631d
d0e95c6
d0af406
1834cd2
84ec340
733d96d
91ff904
33d3f82
03cd7b2
befc8a9
874a22b
ea2f5e8
09fec3b
5e8236a
3241f2d
79b5c35
9bc8d54
800b6d3
dd527e0
fb246b6
1850236
de908d6
2cf7a99
1bacfac
e2fd6b7
810a52c
038b77b
f33d42f
51c6462
4d7fbc2
c4fd31d
7630aae
bd50178
8276cae
a841db0
14428e0
4c3c021
aa10636
2d10a34
00ddfeb
3ce001e
8b4f35b
32b30e2
cfa0c27
97c09ca
80728cb
4ba394c
b0ca497
5b80f1d
13c3369
076c939
52a8812
367cf5c
c729cf4
4a07121
f273299
339ac19
f709963
4bc4ab7
7e14bcc
8138130
0ebe5c3
080b0cc
9a1d4fd
92e90bd
8563d6c
512c48e
c55560b
a2c9ae6
d1610fc
6759ce7
022fb94
81f6e89
6126085
d2660ac
fe10d81
d16bcfb
2529591
45a39e9
c17d852
aae91e9
094707a
edf2953
ed68760
6cfd9d1
799997f
1b2976c
91c871c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same comment here - lets remove these two files and add
.vscode
to.gitignore
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added .vscode/settings.json and .vscode/launch.json to the .gitignore. Not sure how to proceed - surely I can't just delete the files ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't used vscode before. If you delete these files, will the software not work anymore? If so, here is a workaround:
If vscode autogenerates these files, then no need to do the whole mv .vscode_temp rigamarole.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
f strings are legit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason to not accept this "suggestion"? Github makes these "suggestions" easy to manage. Let's hop on a call next week to discuss :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@diskontinuum - let's discuss how to "accept" a commit via the github gui. it really is quite nice! (and is very close to zero effort)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gwaygenomics : I kept ingest.py as an unmodified copy of the original :) , hence I did not introduce any changes.
The modified code is in ingest_incl_parquet.py, where I introduced the fstring for this list comprehension :) .
BTW, this suggestion failed at the Travis CI - I then rewrote the line without ist comprehensions (or fstrings).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor style suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this comment still needs addressing