Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(codecov): fix errors with automated coverage #432

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

d33bs
Copy link
Member

@d33bs d33bs commented Sep 13, 2024

Description

This PR addresses an issue we were having with Codecov running code coverage reports from GitHub Actions. Errors were silently failed due to how they were configured. The errors which appear to have been regarding rate limiting were fixed by updating the version of the Codecov Action which is used to the latest major revision. Successful runs can be exhibited within this PR (see the commenter below).

Moving forward I've "unsilenced" this step within CI to better observe errors in the future.

Closes #431

What is the nature of your change?

  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

Checklist

Please ensure that all boxes are checked before indicating that a pull request is ready for review.

  • I have read the CONTRIBUTING.md guidelines.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have deleted all non-relevant text in this pull request template.

@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.72%. Comparing base (c782728) to head (7149c08).
Report is 29 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #432      +/-   ##
==========================================
- Coverage   94.72%   94.72%   -0.01%     
==========================================
  Files          56       57       +1     
  Lines        3147     3145       -2     
==========================================
- Hits         2981     2979       -2     
  Misses        166      166              
Flag Coverage Δ
unittests 94.72% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@d33bs d33bs changed the title Address Codecov issues ci(codecov): fix errors with automated coverage Sep 13, 2024
@d33bs d33bs marked this pull request as ready for review September 13, 2024 20:34
Copy link
Member

@gwaybio gwaybio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge at will! Thanks for tracking this down...

@d33bs
Copy link
Member Author

d33bs commented Sep 13, 2024

Thanks @gwaybio ! Merging this in now.

@d33bs d33bs merged commit f4885ff into cytomining:main Sep 13, 2024
11 checks passed
@d33bs d33bs deleted the fix-codecov branch September 13, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-enable code coverage analysis for PR's and latest commits
3 participants