Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: exclude scipy, sqlachemy, pandas from groups updates #471

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

kenibrewer
Copy link
Member

@kenibrewer kenibrewer commented Nov 1, 2024

Description

The most recent dependabot groups PR failed due to changes in pandas. Due to the importance of pandas and scipy to the pycytominer codebase and a higher likelihood of breaking changes, I propose we separate them from the grouped updates.

What is the nature of your change?

  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

Checklist

Please ensure that all boxes are checked before indicating that a pull request is ready for review.

  • I have read the CONTRIBUTING.md guidelines.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have deleted all non-relevant text in this pull request template.

@kenibrewer kenibrewer requested a review from d33bs November 1, 2024 09:31
@kenibrewer
Copy link
Member Author

@d33bs Any other high risk packages we want to identify at this time? Alternately, we could just merge a smaller set of excludes, and monitor if other packages regularly cause problems.

@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.73%. Comparing base (3ca794a) to head (1e2f17c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #471   +/-   ##
=======================================
  Coverage   94.73%   94.73%           
=======================================
  Files          57       57           
  Lines        3155     3155           
=======================================
  Hits         2989     2989           
  Misses        166      166           
Flag Coverage Δ
unittests 94.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.github/dependabot.yml Show resolved Hide resolved
@kenibrewer kenibrewer changed the title ci: exclude scipy and pandas from groups updates ci: exclude scipy, sqlachemy, pandas from groups updates Nov 1, 2024
@kenibrewer kenibrewer merged commit 3f82cc4 into main Nov 1, 2024
11 checks passed
@kenibrewer kenibrewer deleted the ci/exclude-pandas-and-scipy-dependabot branch November 1, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants