Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coherent #175

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Coherent #175

wants to merge 5 commits into from

Conversation

YangLiujames
Copy link
Contributor

No description provided.

@YangLiujames YangLiujames self-assigned this Aug 3, 2023
@YangLiujames YangLiujames marked this pull request as draft August 3, 2023 20:26
Copy link
Contributor

@edyoshikun edyoshikun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whenever you have time, we should probably add the laser abstract class, adapt this PR, which just needs some remaining and I can implement it on #161.

@YangLiujames
Copy link
Contributor Author

Whenever you have time, we should probably add the laser abstract class, adapt this PR, which just needs some remaining and I can implement it on #161.

sounds good to me or I can put it in here as well. Maybe we can come up some functions for the abstract class?
def laser_on():

def laser_off():

def set_power():

def set_cw_mode():

def set_digital_modulation_mode():

def check_laser_status():

@edyoshikun
Copy link
Contributor

merge solution to #180 before this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants