Abort stalled acquisitions #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@talonchandler @edyoshikun can I get an approval for this PR? |
talonchandler
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #26 is not completely gone and the Oryx camera will every now and then drop a frame (once in a 8-hour acquisition?), leading to #41. In this PR I abort CZYX acquisitions which are taking too long such that we can proceed with the next timepoint. Tested and works well, ready to merge.
With the new version of pycromanager I observed no slowdown in a 3 hour acquisition, which was the original motivation for #22.
Separately, I'll look into why the camera may be dropping frames as outlined in #26 to get to the source of the issue.
Fixes #64, #41
Requires AcqEngJ 0.30.1 which, for now, I compile manually.