-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrated Slack Action #88
base: dev
Are you sure you want to change the base?
Conversation
Pull Request Test Coverage Report for Build 108
💛 - Coveralls |
Hi there :) Thank you for your work! Could you please check, why your PR does not work on Python 3.4 and 3.5? Is there no slack package for those versions? |
The slack sdk (current v2) was only built for Python 3.6+, while v1 of the sdk supports Python 2.x, according to the official docs |
Would there be any possibility to try-except the imports so that it uses another sdk depending on the runtime environment? I am thinking of something similar to this: That would be pretty awesome, because I don't want to drop support for Python 3.4 yet. I know it's EOL already, but to me it makes sense supporting it for a few months. EDIT: And afaik 3.5 is not EOL yet, so it would be nice to support that at least. Would be very cool if you could check if it works as I suggested and if yes, implement it. If it does not work, could you please raise an error on init? Thank you very much :) |
I can use the v1 (2.x) API if v2 (3.6.x+) raises an error, like the link you posted, but it still wouldn't work for 3.4 as there it isn't supported by API. |
else: | ||
paste_dict = paste.to_dict() | ||
paste_dict["analyzer_name"] = analyzer_name | ||
text = self.template.safe_substitute(DictWrapper(paste_dict)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Big plus for the templating :) thank you very much,
Alright, thanks for getting back. I will think about how to handle it in a nice way. |
Time has passed, and the README says that anything below 3.6 isn't supported anyways, so I suppose the problem with 3.4/3.5 is out of the way? |
Created the Slack action based on existing template(s). Should work, however, token not stored as environment config and Slack message API response was not checked (asserted).