refs matomo-org#5414 this should fix the seg fault on PHP 5.3.6. I di…

…d install an Apache + PHP 5.3.6 and was able to reproduce
d19dotca · Aug 19, 2014 · 3252814 · 3252814
1 parent f1c0eac
commit 3252814
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/core/Plugin/Settings.php b/core/Plugin/Settings.php
@@ -125,11 +125,14 @@ public function getSettingsForCurrentUser()
             return $setting->isWritableByCurrentUser();
         });
 
-        uasort($settings, function ($setting1, $setting2) use ($settings) {
+        $settings2 = $settings;
+
+        uasort($settings, function ($setting1, $setting2) use ($settings2) {
+
             /** @var Setting $setting1 */ /** @var Setting $setting2 */
             if ($setting1->getOrder() == $setting2->getOrder()) {
                 // preserve order for settings having same order
-                foreach ($settings as $setting) {
+                foreach ($settings2 as $setting) {
                     if ($setting1 === $setting) {
                         return -1;
                     }