Skip to content

Commit

Permalink
Added ORDER BY NULL optimisation, fixing unit tests
Browse files Browse the repository at this point in the history
  • Loading branch information
mattab committed Dec 5, 2014
1 parent 46629d9 commit 64bc69c
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions tests/PHPUnit/Integration/SegmentTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,7 @@ public function testGetSelectQueryJoinActionOnVisit()
AND
( log_link_visit_action.custom_var_k1 = ? AND log_visit.visitor_returning = ? )
GROUP BY log_visit.idvisit
ORDER BY NULL
) AS log_inner",
"bind" => array(1, 'Test', 0));

Expand Down Expand Up @@ -300,6 +301,7 @@ public function testGetSelectQueryJoinConversionOnVisit()
AND
( log_conversion.idgoal = ? )
GROUP BY log_visit.idvisit
ORDER BY NULL
) AS log_inner",
"bind" => array(1, 1));

Expand Down Expand Up @@ -423,6 +425,7 @@ public function testGetSelectQueryJoinConversionAndActionOnVisit()
WHERE
log_conversion.idgoal = ? AND HOUR(log_visit.visit_last_action_time) = ? AND log_link_visit_action.custom_var_k1 = ?
GROUP BY log_visit.idvisit
ORDER BY NULL
) AS log_inner",
"bind" => array(1, 12, 'Test'));

Expand Down

0 comments on commit 64bc69c

Please sign in to comment.