Skip to content

Commit

Permalink
Fix regression when metric changed in multi row evolution popup.
Browse files Browse the repository at this point in the history
  • Loading branch information
diosmosis committed Dec 3, 2014
1 parent cadc3b1 commit e244da0
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions plugins/CoreHome/javascripts/dataTable_rowactions.js
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ DataTable_RowActions_RowEvolution.prototype.doOpenPopover = function (urlParam)
// assume the parameter is an int/string describing whether to use multi row evolution
if (extraParamsString == '1') {
extraParams.action = 'getMultiRowEvolutionPopover';
} else if (extraParams != '0') {
} else if (extraParamsString != '0') {
extraParams.action = 'getMultiRowEvolutionPopover';
extraParams.column = extraParamsString;
}
Expand Down Expand Up @@ -376,7 +376,8 @@ DataTable_RowActions_RowEvolution.prototype.showRowEvolution = function (apiMeth
box.find('select.multirowevoltion-metric').change(function () {
var metric = $(this).val();
Piwik_Popover.onClose(false); // unbind listener that resets multiEvolutionRows
self.openPopover(apiMethod, metric, label);
var extraParams = {action: 'getMultiRowEvolutionPopover', column: metric};
self.openPopover(apiMethod, extraParams, label);
return true;
});
};
Expand Down

0 comments on commit e244da0

Please sign in to comment.