-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade colored and prepare for 0.7.0 release #128
Conversation
CHANGELOG.md
Outdated
@@ -1,6 +1,14 @@ | |||
Unreleased | |||
========== | |||
|
|||
|
|||
0.7.0 (2023-07-12) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The date might need to be adjusted unless this PR is accepted quickly. Or the package maintainers might want to handle this part of releasing themselves? Just tell me how you want it. I went with the path where this PR does everything needed before cargo publish
for now, to make it easy :)
What we can do is to run the CI on We can also simply bump |
Other options would be to run the MSRV CI with |
I'll let the maintainers of |
This PR has been left open for a while, and no new commits to Perhaps @daboross could add some additional maintainers?
You can use Useful for generating a Just to clarify, a project can set an MSRV and ensure that it satisfies that MSRV via CI, but this does not require the ability to have the MSRV supported without version pinning. It's the same as what the user would need to do to build with the MSRV, bumping it to avoid any pinning is just for convenience.
Upstream dependencies can MSRV bump as non-breaking semver change without issue, especially when they leverage
TL;DR
|
Bump |
0845bf5
to
2ffe0b2
Compare
d9f2827
to
d85f7d0
Compare
The original reason for this PR is gone (getting rid of I went with the solution to check in a EDIT: I have not yet been able to craft a perectly working
But I'll continue investigating when I have time and try to handpick a combination of crates that do work. |
The code did not change, but since the CI now uses a checked in Cargo.lock.msrv of the new lockfile format introduced in Rust 1.38.
96955cf
to
7b4d4d6
Compare
@faern Thank you for making this! And sorry to leave it completely unattended for ~15 months. @polarathene you're correct that I've left this crate unmaintained - not an ideal state for something people depend on. I think I'm not the most reliable maintainer here, but given things like this tend to come up infrequently, I don't think it's that urgent. In any case, I'll be making a new In the past I've just upped the MSRV to whatever |
That's ok, it happens. See I think you could probably engage with |
Fixes #113