Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add update subscription with cron job support #138

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

EkkoG
Copy link
Contributor

@EkkoG EkkoG commented Jan 29, 2024

Background

For now, subscription cannot be updated after it be added, this PR add ability update subscription with a cron job, frontend can add a dialog to let users fill a cron job expression or a duration like update per hour.

Checklist

Full Changelogs

  • Support update subscription with cron job

Issue Reference

no

Test Result

CleanShot 2024-01-29 at 18 13 34@2x

@EkkoG EkkoG requested a review from a team as a code owner January 29, 2024 10:20
@dae-prow dae-prow bot assigned EkkoG Jan 29, 2024
Copy link
Contributor

@sumire88 sumire88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EkkoG Would you like to propose the required changes in daed as well?

db/subscription.go Outdated Show resolved Hide resolved
@sumire88 sumire88 changed the title Add update subscription with cron job support feat: add update subscription with cron job support Jan 29, 2024
@EkkoG
Copy link
Contributor Author

EkkoG commented Mar 27, 2024

daed need add some interface to allow user set cron expression or frequency of update task to run, like every 6 hours, I'm not familiar with daed so I cannot pr to daed for now.

graphql/mutation.go Outdated Show resolved Hide resolved
@wanlce wanlce requested a review from mzz2017 July 28, 2024 05:15
mzz2017
mzz2017 previously approved these changes Sep 28, 2024
@wanlce
Copy link
Contributor

wanlce commented Oct 16, 2024

@EkkoG 目前此PR虽然可以实现自动更新订阅,但是订阅更新后仍需手动 reload 或者重启之后才可以生效(
用以下逻辑来替代怎么样,这样前端好改

  • reload 操作会先更新订阅
  • 添加自动 reload 的开关和 Cron Expression

这样就完成了自动订阅更新并生效了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants