fix: reject reason on notification

__tests__/notifications/index.ts

@@ -59,6 +59,7 @@ import { NotificationType } from '../../src/notifications/common';
 import { format } from 'date-fns';
 import { saveFixtures } from '../helpers';
 import {
+  PostModerationReason,
   SourcePostModeration,
   SourcePostModerationStatus,
 } from '../../src/entity/SourcePostModeration';
@@ -1324,7 +1325,7 @@ describe('storeNotificationBundle', () => {
       sourceId: 'a',
       createdById: '2',
       status: SourcePostModerationStatus.Rejected,
-      rejectionReason: 'Other',
+      rejectionReason: PostModerationReason.Other,
       moderatorMessage: 'Lacks value.',
     });
     const type = NotificationType.SourcePostRejected;

src/entity/SourcePostModeration.ts

@@ -17,6 +17,34 @@ export enum SourcePostModerationStatus {
   Pending = 'pending',
 }
 
+export enum PostModerationReason {
+  OffTopic = 'OFF_TOPIC',
+  Violation = 'VIOLATION',
+  Promotional = 'PROMOTIONAL',
+  Duplicate = 'DUPLICATE',
+  LowQuality = 'LOW_QUALITY',
+  NSFW = 'NSFW',
+  Spam = 'SPAM',
+  Misinformation = 'MISINFORMATION',
+  Copyright = 'COPYRIGHT',
+  Other = 'OTHER',
+}
+
+export const rejectReason: Record<PostModerationReason, string> = {
+  [PostModerationReason.OffTopic]: 'Off-topic post unrelated to the Squad',
+  [PostModerationReason.Violation]: 'Violates the Squad’s code of conduct',
+  [PostModerationReason.Promotional]: 'Too promotional without adding value',
+  [PostModerationReason.Duplicate]:
+    'Duplicate or similar content already posted',
+  [PostModerationReason.LowQuality]: 'Lacks quality or clarity',
+  [PostModerationReason.NSFW]: 'Inappropriate, NSFW or offensive post',
+  [PostModerationReason.Spam]: 'Post is spam or scam',
+  [PostModerationReason.Misinformation]:
+    'Contains misleading or false information',
+  [PostModerationReason.Copyright]: 'Copyright or privacy violation',
+  [PostModerationReason.Other]: 'Other',
+};
+
 @Entity()
 @Index(['sourceId'])
 @Index(['sourceId', 'createdById'])
@@ -58,7 +86,7 @@ export class SourcePostModeration {
   moderatorMessage?: string | null;
 
   @Column({ type: 'text', nullable: true })
-  rejectionReason?: string | null;
+  rejectionReason?: PostModerationReason | null;
 
   @CreateDateColumn()
   createdAt: Date;

src/notifications/generate.ts

@@ -31,6 +31,7 @@ import { UPVOTE_TITLES } from '../workers/notifications/utils';
 import { checkHasMention } from '../common/markdown';
 import { NotificationType } from './common';
 import { format } from 'date-fns';
+import { rejectReason } from '../entity/SourcePostModeration';
 
 const systemTitle = () => undefined;
 
@@ -135,8 +136,12 @@ export const notificationTitleMap: Record<
   },
   source_post_approved: (ctx: NotificationPostContext) =>
     `Woohoo! Your post has been approved and is now live in ${ctx.source.name}. Check it out!`,
-  source_post_rejected: (ctx: NotificationPostModerationContext) =>
-    `Your post in ${ctx.source.name} was not approved for the following reason: ${ctx.post.rejectionReason}. Please review the feedback and consider making changes before resubmitting.`,
+  source_post_rejected: (ctx: NotificationPostModerationContext) => {
+    const reason = ctx.post.rejectionReason
+      ? rejectReason[ctx.post.rejectionReason]
+      : rejectReason.OTHER;
+    return `Your post in ${ctx.source.name} was not approved for the following reason: ${reason}. Please review the feedback and consider making changes before resubmitting.`;
+  },
   source_post_submitted: (ctx: NotificationPostModerationContext) =>
     `${ctx.user.name} just posted in ${ctx.source.name}. This post is waiting for your review before it gets published on the squad.`,
 };