Prime for Next Release

.github/ISSUE_TEMPLATE/bug_report.yml

@@ -1,5 +1,5 @@
 name: Bug Report
-description: Report a problem with RefindPlus
+description: Report a Problem with RefindPlus
 body:
   - type: markdown
     attributes:
@@ -14,7 +14,7 @@ body:
       label: RefindPlus Version
       description: Which version of RefindPlus is affected?
       options:
-        - 'v0.14.1.AA Release'
+        - 'v0.14.2.AA Release'
         - 'Older Released Version'
         - 'Pre-Release Code Build'
     validations:

.github/ISSUE_TEMPLATE/feature-request.yml

@@ -1,5 +1,5 @@
 name: Feature Request
-description: Suggest improvements to RefindPlus
+description: Suggest Improvements to RefindPlus
 body:
   - type: markdown
     attributes:

.github/label-config.yml

@@ -628,6 +628,13 @@ Cannot-Replicate:
     # Close thread
     close: true
 
+# The `Cannot-Replicate` label is removed from issues
+-Cannot-Replicate:
+  issues:
+    # Reopen issue and unlock thread
+    reopen: true
+    unlock: true
+
 # The `Prorogued` label is added to issues
 Prorogued:
   issues:

.github/workflows/issue_helper_resolve_bug.yml

@@ -48,11 +48,10 @@ jobs:
         with:
           github-token: ${{ secrets.GITHUB_TOKEN }}
           script: |
-            const issueNumber = context.payload.inputs.item_id;
-            const { data } = await github.issues.get({
+            const { data } = await github.rest.issues.get({
               owner: context.repo.owner,
               repo: context.repo.repo,
-              issue_number: issueNumber
+              issue_number: context.payload.inputs.item_id
             });
             if (data.locked) {
               console.log("::set-output name=islocked::true");

.github/workflows/issue_helper_resolve_other.yml

@@ -45,11 +45,10 @@ jobs:
         with:
           github-token: ${{ secrets.GITHUB_TOKEN }}
           script: |
-            const issueNumber = context.payload.inputs.item_id;
-            const { data } = await github.issues.get({
+            const { data } = await github.rest.issues.get({
               owner: context.repo.owner,
               repo: context.repo.repo,
-              issue_number: issueNumber
+              issue_number: context.payload.inputs.item_id
             });
             if (data.locked) {
               console.log("::set-output name=islocked::true");

BootMaster/launch_efi.c

@@ -747,7 +747,8 @@ EFI_STATUS StartEFIImage (
             );
             if (EFI_ERROR(ReturnStatus)) {
                 CheckError (
-                    ReturnStatus, L"while Getting LoadedImageProtocol Handle"
+                    ReturnStatus,
+                    L"While Getting 'Child' LoadedImageProtocol Handle"
                 );
 
                 // Unload and Bail Out

BootMaster/launch_legacy.c

@@ -479,7 +479,10 @@ EFI_STATUS StartLegacyImageList (
         &LoadedImageProtocol, (VOID **) &ChildLoadedImage
     );
     if (EFI_ERROR(Status)) {
-        CheckError (Status, L"While Fetching LoadedImageProtocol Handle");
+        CheckError (
+            Status,
+            L"While Fetching 'Child' LoadedImageProtocol Handle"
+        );
         if (ErrorInStep != NULL) {
             *ErrorInStep = 2;
         }

BootMaster/lib.c

@@ -620,7 +620,11 @@ EFI_STATUS InitRefitLib (
         &LoadedImageProtocol, (VOID **) &SelfLoadedImage
     );
     if (EFI_ERROR(Status)) {
-        CheckFatalError (Status, L"While Getting a LoadedImageProtocol Handle");
+        CheckFatalError (
+            Status,
+            L"While Getting 'Self' LoadedImageProtocol Handle"
+        );
+
         return EFI_LOAD_ERROR;
     }
 

CHANGELOG.txt

@@ -1,3 +1,8 @@
+0.14.2.AB (PRE-RELEASE):
+-----------------------
+- PENDING
+
+
 0.14.2.AA (08 OCT 2024):
 -----------------------
 - Synced with Upstream v0.14.2
@@ -7,7 +12,7 @@
   * This bug was inherited from upstream code
 - Fixes `ScanFirmwareDefined` Handling
   * Spurious items were added (Typically as firmware shell instances)
-    - Ref: https://github.com/dakanji/RefindPlus/issues/184
+    - Ref: Issue https://github.com/dakanji/RefindPlus/issues/184
   * This bug was introduced in v0.14.0.AC (Commit aad3298)
 - Fixes Jpeg Image Handling
   * Garbled images were output
@@ -16,23 +21,23 @@
       * `#define memset MyMemSet` to `#define memset(b, c, v) MyMemSet(b, v, c)` in `libeg/nanojpeg.c`
     - These parameters had already been reversed elsewhere in v0.13.2.AG (Commit 2d8ab59)
       * Ported from @joevt downstream: https://github.com/joevt/RefindPlus/commit/266fd8f
-    - The changes previously invalidated each other
+    - The cumulative changes invalidated each other
 - Fixes `UGA Graphics` Handling
-  * RefindPlus Crashed when run with UGA-based GPUs
+  * RefindPlus crashed when run with UGA-based GPUs
 - Improves `HelpIcon` Handling
   * The `os_uefi` icon is now cached on first use
   * Misc other icon caching related optimisations
 - Improves `.VolumeIcon` Handling
-  * These can now the located under the same folder as a loader
-  * Such are preferred over any in the volume root
+  * These can now be located under the same folder as a loader
+  * Such are preferred over any in the default (volume root) location
 - Improves `Misc` Handling
   * Some entry types were mislabelled as `Linux`
   * Now recognises `Linux Unified Key Setup (LUKS)` encrypted volumes
   * Now limits `spoof_osx_version` to Apple firmware to match documentation
   * No longer attempts to clear the `opencore-version` variable when booting into Mac OS
     - This variable is actually only stored in a volatile state
   * Addressed misc static analysis flags
-    - These apply to some filesystem drivers; which are updated accordingly
+    - These affect some filesystem drivers; which are updated accordingly
 - Amends `HelpScan` Feature
   * The feature is now essentially included upstream
   * Now removed as a standalone feature in RefindPlus and active as a default core item
@@ -45,9 +50,9 @@
         - `memtest` and `memtestXYZ` folders are scanned
         - Memtest fallback loader files (`Boot{arch}.efi`) are handled
   * Adds `tools` option to `use_graphics_for` configuration token
-    - These can now be set to load in graphics screen mode
+    - These can now be set to load in `graphics screen mode`
     - Verbose screen output is disabled when set to use graphics
-    - NB: Some tools, such as some uEFI shell, may require text mode
+    - NB: Some tools, such as some uEFI shell, may require `text screen mode`
 - Amends `Ventoy` Handling
   * Instances are now automatically detected and processed
     - Hence, specific handling is no longer user configurable

README-Dev.md

@@ -23,7 +23,7 @@ RefindPlus builds on _`rEFInd`_ to extend its functionality with enhancements an
 RefindPlus is particularly useful for those with additional configuration needs or that require advanced or otherwise non-typical options for running operating systems and uEFI utilities on Mac and PC.
 
 Some features:
-- Maintains feature and configuration parity with the base upstream version.
+- Maintains feature and configuration parity with `Upstream v0.14.2` base.
 - Provides protection against damage to vulnerable Mac nvRAM by UEFI Windows boot.
 - Provides mitigation against boot failures and related issues on T2/TPM chipped units.
 - Provides Pre-Boot Configuration Screen on units running GPUs without native EFI on Macs.
@@ -71,7 +71,7 @@ RefindPlus will function with the upstream configuration file, `refind.conf`, bu
 >
 > RefindPlus-specific options can also be simply added to upstream configuration files.
 
-When run without activating RefindPlus-specific configuration options, as will be the case with unmodified upstream configuration files, a RefindPlus run will be equivalent to running the upstream version it is based on, currently v0.14.2. That is, the additional options provided in RefindPlus must be actively enabled if they are required.
+When run without activating RefindPlus-specific configuration options, as will be the case with unmodified upstream configuration files, a RefindPlus run will be equivalent to running the upstream version it is based on. That is, the additional options provided in RefindPlus must be actively enabled if they are required.
 
 > [!NOTE]
 >

README.md

@@ -23,7 +23,7 @@ RefindPlus builds on _`rEFInd`_ to extend its functionality with enhancements an
 RefindPlus is particularly useful for those with additional configuration needs or that require advanced or otherwise non-typical options for running operating systems and uEFI utilities on Mac and PC.
 
 Some features:
-- Maintains feature and configuration parity with the base upstream version.
+- Maintains feature and configuration parity with `Upstream v0.14.2` base.
 - Provides protection against damage to vulnerable Mac nvRAM by UEFI Windows boot.
 - Provides mitigation against boot failures and related issues on T2/TPM chipped units.
 - Provides Pre-Boot Configuration Screen on units running GPUs without native EFI on Macs.
@@ -71,7 +71,7 @@ RefindPlus will function with the upstream configuration file, `refind.conf`, bu
 >
 > RefindPlus-specific options can also be simply added to upstream configuration files.
 
-When run without activating RefindPlus-specific configuration options, as will be the case with unmodified upstream configuration files, a RefindPlus run will be equivalent to running the upstream version it is based on, currently v0.14.2. That is, the additional options provided in RefindPlus must be actively enabled if they are required.
+When run without activating RefindPlus-specific configuration options, as will be the case with unmodified upstream configuration files, a RefindPlus run will be equivalent to running the upstream version it is based on. That is, the additional options provided in RefindPlus must be actively enabled if they are required.
 
 > [!NOTE]
 >

include/version.h

@@ -16,4 +16,4 @@
  * Modifications distributed under the preceding terms.
  */
 
-#define REFINDPLUS_VERSION L"0.14.2.AA"
+#define REFINDPLUS_VERSION L"0.14.2.AB (PRE-RELEASE)"