Refactor internal functions to use opts map #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many internal functions had two or three arguments for customizing behavior. Since we'd like to be able to add more customization in the future, condensing these into an options map seems like a good move. One subtle difference introduced is that the functions which previously read a :date-format value from a map and used `or` to determine whether to used the default-date-format, now use `merge` and so have different behavior if the `:date-format` key is present but `nil`. I'm assuming this will be fine.
|
This is of course w.r.t. #77. |
|
Okay, so having a child has unfortunately sucked up a lot of my time for open source projects, so let's improve the community! @gfredericks I've added you as a contributor to the project, if you want to merge this (run the benchmarks first please!) that would be great! I'll continue to help with issues but I don't want to be a blocker :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many internal functions had two or three arguments for customizing
behavior. Since we'd like to be able to add more customization in the
future, condensing these into an options map seems like a good move.
One subtle difference introduced is that the functions which previously
read a :date-format value from a map and used
orto determine whetherto used the default-date-format, now use
mergeand so have differentbehavior if the
:date-formatkey is present butnil. I'm assumingthis will be fine.