-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement no_std support #280
Merged
Merged
Changes from 36 commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
c4499ab
turn off default features in Cargo.toml, and define and select as app…
xoloki 91d36eb
use dependency injection to pass RNGs around rather than creating the…
xoloki 5984ec0
include std/alloc explicitly for curve25519-dalek since we aren't get…
xoloki bb86ad1
use merlin from fork for nostd fixes
xoloki dd4ee75
turn off fancy serde error code to try to fix nostd errors
xoloki be9c393
use upstream dalek curve release, without using serde; remove all nai…
xoloki 84e6924
add byte buffer data structures to enable naive serialization without…
xoloki 93842a7
add no_std cfg_attr in base lib.rs; remove unused serialization code …
xoloki 5f6d068
only reference core directly if we're in std mode; if we're in alloc …
xoloki 23813f1
try putting cfg_if in generators to pickup alloc Vec
xoloki 06f5e81
use cfg_if to pickup Vec in alloc mode
xoloki f0d37d0
use cfg_if to pickup Vec in alloc mode
xoloki 9c2bc09
use cfg_if to pickup iter and Borrow in alloc mode
xoloki 60eb7e8
use core::iter; replace vec! usage
xoloki d01f0c6
remove println
xoloki baa759f
re-enable range proof serialzation
xoloki de18a44
use naive curve point serialization in internal data structures
xoloki 196f072
make API backward compatible in std mode, renaming templated function…
xoloki 332458f
remove unnecessary import and use of ThreadRng; make standardized ref…
xoloki f929674
use version only major version for curve25519 dependency
xoloki 602d600
force usage of curve25519 1.2.x
xoloki dac9547
use updated merlin without alloc target
xoloki b921580
fix existing test and build errors; pass rng where necessary to helpe…
xoloki 4c8179b
fix bad rebase
xoloki 093315f
test is failing upstream so leave it
xoloki 7facdf8
use rand 0.6 to avoid std errors during no_std build
xoloki 4aa64c9
fmt fixes
xoloki f248649
fix bad rebase
xoloki c664af1
remove new use of vec! from develop branch
xoloki 931288d
fix yoloproofs, only include them in std mode
xoloki b935b5b
remove cfg_if and just repeat cfg directives as necessary; use alloc:…
xoloki c70332d
make rand dependency optional, and select it always when std feature …
xoloki dc1238b
remove alloc feature and just use alloc everywhere, now building with…
xoloki ee0678e
pull in review changes
xoloki c1890b1
Merge branch 'develop' into nostd
xoloki 415e355
fmt fixes
xoloki b451bcc
keep public API backwards compatible when in std mode
xoloki 04533f5
Fix bad copypasta, remove template parameters
xoloki 4a523df
revert test change to disable test that was failing locally
xoloki 76c0e75
restore original test code
hdevalence File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this needs to be a new
receive_shares_with_rng
function, becausereceive_shares
is part of the public API and can't change without a major version bump.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I'll rework these so the API doesn't change in std mode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Sorry again for missing this on the first pass of review 😞