Merge pull request #1884 from timdeschryver/angular-17

feat: upgrade to Angular 17
damienbod · Jan 4, 2024 · 2a2ca06 · 2a2ca06
2 parents d71e3bf + 0650b56
commit 2a2ca06
Show file tree

Hide file tree

Showing 23 changed files with 7,149 additions and 17,907 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -40,7 +40,8 @@
         "@typescript-eslint/ban-types": ["error"],
         "no-useless-escape": ["error"],
         "no-prototype-builtins": ["error"],
-        "prefer-spread": ["error"]
+        "prefer-spread": ["error"],
+        "@typescript-eslint/no-explicit-any": "off"
       }
     },
     {

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -22,7 +22,7 @@ jobs:
       - name: Setup Node.js
         uses: actions/setup-node@v2
         with:
-          node-version: 16
+          node-version: 20
 
       - name: Installing Dependencies
         run: npm ci
@@ -68,7 +68,7 @@ jobs:
       - name: Setup Node.js
         uses: actions/setup-node@v2
         with:
-          node-version: 16
+          node-version: 20
 
       - name: Download Artefact
         uses: actions/download-artifact@v2
@@ -77,7 +77,7 @@ jobs:
           path: angular-auth-oidc-client-artefact
 
       - name: Install AngularCLI globally
-        run: sudo npm install -g @angular/cli@16
+        run: sudo npm install -g @angular/cli
 
       - name: Show ng Version
         run: ng version
@@ -108,7 +108,7 @@ jobs:
       - name: Setup Node.js
         uses: actions/setup-node@v2
         with:
-          node-version: 16
+          node-version: 20
 
       - name: Download Artefact
         uses: actions/download-artifact@v2
@@ -117,7 +117,7 @@ jobs:
           path: angular-auth-oidc-client-artefact
 
       - name: Install AngularCLI globally
-        run: sudo npm install -g @angular/cli@16
+        run: sudo npm install -g @angular/cli
 
       - name: Show ng Version
         run: ng version
@@ -140,15 +140,15 @@ jobs:
         working-directory: ./angular-auth-oidc-client-test
         run: sudo npm run build
 
-  AngularLatestVersionWithStandaloneSchematics:
+  AngularLatestVersionWithNgModuleSchematics:
     needs: build_job
     runs-on: ubuntu-latest
     name: Angular latest Standalone & Schematics Job
     steps:
       - name: Setup Node.js
         uses: actions/setup-node@v2
         with:
-          node-version: 16
+          node-version: 20
 
       - name: Download Artefact
         uses: actions/download-artifact@v2
@@ -157,13 +157,13 @@ jobs:
           path: angular-auth-oidc-client-artefact
 
       - name: Install AngularCLI globally
-        run: sudo npm install -g @angular/cli@16
+        run: sudo npm install -g @angular/cli
 
       - name: Show ng Version
         run: ng version
 
       - name: Create Angular Project
-        run: sudo ng new angular-auth-oidc-client-test --skip-git --standalone
+        run: sudo ng new angular-auth-oidc-client-test --skip-git --standalone=false
 
       - name: Npm Install & Install Library from local artefact
         run: |
@@ -188,7 +188,7 @@ jobs:
       - name: Setup Node.js
         uses: actions/setup-node@v2
         with:
-          node-version: 16
+          node-version: 20
 
       - name: Download Artefact
         uses: actions/download-artifact@v2
@@ -197,7 +197,7 @@ jobs:
           path: angular-auth-oidc-client-artefact
 
       - name: Install AngularCLI globally
-        run: sudo npm install -g @angular/cli@16
+        run: sudo npm install -g @angular/cli
 
       - name: Show ng Version
         run: ng version
@@ -224,6 +224,46 @@ jobs:
         working-directory: ./angular-auth-oidc-client-test
         run: sudo npm run build
 
+  LibWithAngularV16:
+      needs: build_job
+      runs-on: ubuntu-latest
+      name: Angular V16
+      steps:
+        - name: Setup Node.js
+          uses: actions/setup-node@v2
+          with:
+            node-version: 18
+
+        - name: Download Artefact
+          uses: actions/download-artifact@v2
+          with:
+            name: angular_auth_oidc_client_artefact
+            path: angular-auth-oidc-client-artefact
+
+        - name: Install AngularCLI globally
+          run: sudo npm install -g @angular/cli@16
+
+        - name: Show ng Version
+          run: ng version
+
+        - name: Create Angular Project
+          run: sudo ng new angular-auth-oidc-client-test --skip-git
+
+        - name: Npm Install & Install Library from local artefact
+          run: |
+            sudo cp -R angular-auth-oidc-client-artefact angular-auth-oidc-client-test/
+            cd angular-auth-oidc-client-test
+            sudo npm install --unsafe-perm=true
+            sudo ng add ./angular-auth-oidc-client-artefact --authority-url-or-tenant-id "my-authority-url" --flow-type "OIDC Code Flow PKCE using refresh tokens" --use-local-package=true --skip-confirmation
+
+        - name: Test Angular Application
+          working-directory: ./angular-auth-oidc-client-test
+          run: npm test -- --watch=false --browsers=ChromeHeadless
+
+        - name: Build Angular Application
+          working-directory: ./angular-auth-oidc-client-test
+          run: sudo npm run build
+
   LibWithAngularV15:
     needs: build_job
     runs-on: ubuntu-latest

diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -1,7 +1,7 @@
 {
   "editor.codeActionsOnSave": {
-    "source.organizeImports": true,
-    "source.fixAll.eslint": true
+    "source.organizeImports": "explicit",
+    "source.fixAll.eslint": "explicit"
   },
   "editor.formatOnSave": true,
   "editor.formatOnPaste": true,