Updated testcases & bugfixes

damienbod · Aug 18, 2023 · 7a846b3 · 7a846b3
1 parent 7ce2647
commit 7a846b3
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 8 deletions.
diff --git a/projects/angular-auth-oidc-client/src/lib/login/par/par-login.service.spec.ts b/projects/angular-auth-oidc-client/src/lib/login/par/par-login.service.spec.ts
@@ -144,7 +144,9 @@ describe('ParLoginService', () => {
       });
 
       expect(result).toBeUndefined();
-      expect(spy).toHaveBeenCalledOnceWith(config, { some: 'thing' });
+      expect(spy).toHaveBeenCalledOnceWith(config, {
+        customParams: { some: 'thing' },
+      });
     }));
 
     it('returns undefined and logs error when no url could be created', waitForAsync(() => {
@@ -184,6 +186,8 @@ describe('ParLoginService', () => {
         responseType: 'stubValue',
       };
 
+      const authOptions = {};
+
       spyOn(
         authWellKnownService,
         'queryAndStoreAuthWellKnownEndPoints'
@@ -195,7 +199,7 @@ describe('ParLoginService', () => {
       spyOn(urlService, 'getAuthorizeParUrl').and.returnValue('some-par-url');
       const spy = spyOn(redirectService, 'redirectTo');
 
-      service.loginPar(config);
+      service.loginPar(config, authOptions);
 
       expect(spy).toHaveBeenCalledOnceWith('some-par-url');
     }));
@@ -306,7 +310,9 @@ describe('ParLoginService', () => {
         })
         .subscribe({
           error: (err) => {
-            expect(spy).toHaveBeenCalledOnceWith(config, { some: 'thing' });
+            expect(spy).toHaveBeenCalledOnceWith(config, {
+              customParams: { some: 'thing' },
+            });
             expect(err.message).toBe(
               "Could not create URL with param requestUri: 'url'"
             );

diff --git a/projects/angular-auth-oidc-client/src/lib/login/par/par.service.ts b/projects/angular-auth-oidc-client/src/lib/login/par/par.service.ts
@@ -21,7 +21,7 @@ export class ParService {
 
   postParRequest(
     configuration: OpenIdConfiguration,
-    authOptions: AuthOptions
+    authOptions?: AuthOptions
   ): Observable<ParResponse> {
     let headers: HttpHeaders = new HttpHeaders();
 

diff --git a/projects/angular-auth-oidc-client/src/lib/utils/url/url.service.spec.ts b/projects/angular-auth-oidc-client/src/lib/utils/url/url.service.spec.ts
@@ -1348,7 +1348,9 @@ describe('UrlService Tests', () => {
       );
 
       const resultObs$ = service.createBodyForParCodeFlowRequest(config, {
-        any: 'otherThing',
+        customParams: {
+          any: 'otherThing',
+        },
       });
 
       resultObs$.subscribe((result) => {

diff --git a/projects/angular-auth-oidc-client/src/lib/utils/url/url.service.ts b/projects/angular-auth-oidc-client/src/lib/utils/url/url.service.ts
@@ -300,7 +300,8 @@ export class UrlService {
 
   createBodyForParCodeFlowRequest(
     configuration: OpenIdConfiguration,
-    authOptions?: AuthOptions): Observable<string> {
+    authOptions?: AuthOptions
+  ): Observable<string> {
     const redirectUrl = this.getRedirectUrl(configuration, authOptions);
 
     if (!redirectUrl) {
@@ -351,8 +352,11 @@ export class UrlService {
           );
         }
 
-        if (authOptions.customParams) {
-          params = this.appendCustomParams({ ...authOptions.customParams }, params);
+        if (authOptions?.customParams) {
+          params = this.appendCustomParams(
+            { ...authOptions.customParams },
+            params
+          );
         }
 
         return params.toString();