Added useCustomAuth0Domain flag #1821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openid-configuration now contains an optional flag to allow custom domains in auth0 to function as normal. A small change in the url service checks if the authority ends with auth0.com OR the useCustomAuth0Domain is set.
|
Thanks for the PR. It would be nice we would extend also the docs with this change. Then it LGTM. |
Yes quite agreed, I will take a look at the docs :) thanks for the feedback. |
|
Haha, nothing to thank for. Thank YOU for the PR! |
Now includes summary of useCustomAuth0Domain flag
|
Configuration doc updated to include a brief description of the useCustomAuth0Domain flag! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Auth0 does not publish it's end_session_url in it's discovery doc special handling is required for logging out.
This special handling of Auth0 logout is not triggered for custom domains since this special handling is determined by whether the authority ends with 'auth0.com'
openid-configuration now contains an optional flag to allow custom domains in auth0 to function as normal.
A small change in the url service checks if the authority ends with auth0.com OR the useCustomAuth0Domain is set.
This is probably quite a niche issue but it has been a real headache for what seems like a simple fix.
(This is my first time ever contributing to any project so apologies in advance if I've missed anything / done anything incorrectly, please do help me to learn I would be very grateful!)