fix: auto login guard passes correct config id #2008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2007
This PR corrects the arguments that are passed to the functional guards.
The second argument is always the state.
Without the parameter the state was passed as config id where
autoLoginPartialRoutesGuardwas used.I tested both guards within the standalone application and everything seems fine after this change.
One question that came to surface was if we should provide a better error message when there's something wrong with the config.
A quick-win that helps the developer is mentioning the config id in the error message.
For example, if an non-existing config id is used with
autoLoginPartialRoutesGuardWithConfigthe following error is thrown, which doesn't help the developer.I can turn this question into an issue and/or PR if you'd like.