Check if URL matches the API URL so we do not hardcode wrong "False" for is_api #1318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just now merged typing fixes PR #1316 , typing errors here seems to be of that PR fixes kind, so unrelated to this PR |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1318 +/- ##
=======================================
Coverage 88.82% 88.82%
=======================================
Files 76 76
Lines 10191 10194 +3
=======================================
+ Hits 9052 9055 +3
Misses 1139 1139
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have spotted odd log msg while preparing example for #1317 (comment):
❯ dandi download --download dandiset.yaml DANDI:000026 2023-08-10 09:41:54,008 [ WARNING] Request to https://api.dandiarchive.org/api failed (404 Client Error: Not Found for url: https://api.dandiarchive.org/api/api/info/) 2023-08-10 09:41:54,008 [ WARNING] Using hard-coded URLs ...which was apparently due to our assumption that provided URL (here from DANDI: identifiers.org redirect) is not API URL. I have not looked deeper into that logic, but rather just fixed checking for known instances in case if URL does match a known API end point.