Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace magic string arguments with enums #1357

Merged
merged 4 commits into from
Nov 17, 2023
Merged

Replace magic string arguments with enums #1357

merged 4 commits into from
Nov 17, 2023

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Nov 10, 2023 •
edited
Loading

No description provided.

@jwodder jwodder added enhancement New feature or request Python API code quality Nonfunctional improvements to the codebase labels Nov 10, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 10, 2023 •
edited
Loading

Codecov Report

Attention: 32 lines in your changes are missing coverage. Please review.

Comparison is base (18126ca) 62.73% compared to head (68ba57c) 89.11%.
Report is 8 commits behind head on master.

Files Patch % Lines
dandi/metadata/nwb.py 81.17% 16 Missing ⚠️
dandi/download.py 85.71% 5 Missing ⚠️
dandi/organize.py 93.65% 4 Missing ⚠️
dandi/upload.py 87.50% 3 Missing ⚠️
dandi/cli/cmd_upload.py 50.00% 2 Missing ⚠️
dandi/move.py 92.00% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #1357       +/-   ##
===========================================
+ Coverage   62.73%   89.11%   +26.37%     
===========================================
  Files          75       77        +2     
  Lines       10278    10361       +83     
===========================================
+ Hits         6448     9233     +2785     
+ Misses       3830     1128     -2702
Flag Coverage Δ
unittests 89.11% <92.03%> (+26.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 10, 2023
View reviewed changes
dandi/files/bases.py Dismissed Show dismissed Hide dismissed
dandi/metadata/nwb.py Dismissed Show dismissed Hide dismissed
@jwodder jwodder marked this pull request as ready for review November 13, 2023 14:20
@jwodder
Replace magic string arguments with enums
2f38f8e
@jwodder
Split up metadata.py
b92c471 
So that common functionality can be imported without failing the "no heavy
imports" test
@jwodder
Avoid importing numpy
8ab9d05
@jwodder
Fixes
68ba57c
@yarikoptic
Copy link
Member

cool!

@yarikoptic yarikoptic merged commit 88cce6b into master Nov 17, 2023
25 checks passed
@yarikoptic yarikoptic deleted the more-enums branch November 17, 2023 03:01
This was referenced Nov 17, 2023
Draft
Draft
@github-actions GitHub Actions
Copy link

🚀 PR was released in 0.58.1 🚀

@github-actions GitHub Actions
Copy link

🚀 PR was released in 0.58.1 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yarikoptic yarikoptic yarikoptic left review comments

Assignees
No one assigned
Labels
code quality Nonfunctional improvements to the codebase enhancement New feature or request Python API released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jwodder @yarikoptic