-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop claiming support and testing against EOL Python 3.8 #1504
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1504 +/- ##
==========================================
+ Coverage 88.56% 88.64% +0.08%
==========================================
Files 77 77
Lines 10572 10572
==========================================
+ Hits 9363 9372 +9
+ Misses 1209 1200 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
not yet, in a month or so whenever it actually EOLs |
The 3.12 Test breaking is unrelated, its just a flake. I bumped the timeout here fwiw. |
I thought it was EOL on October 14, but its gone as of October 7. https://devguide.python.org/versions/ |
Thank you! I am also going through similar fun activities in other corners |
🚀 PR was released in |
🚀 PR was released in |
Fixes #1503