Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove NotImplementedError to allow for uploading Zarr assets to embargoed Dandisets #1540

Merged
merged 6 commits into from
Nov 27, 2024
Merged

Remove NotImplementedError to allow for uploading Zarr assets to embargoed Dandisets #1540

merged 6 commits into from
Nov 27, 2024

Commits on Nov 25, 2024

  1. Remove NotImplementedError to allow for uploading Zarr assets to em… 

    …bargoed Dandisets
    @kabilar
    kabilar committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    445c898 View commit details
    Browse the repository at this point in the history

  2. Remove import

    @kabilar
    kabilar committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    07c840b View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2024

  1. RF + ENH: parametrize test_upload_sync_zarr to test against both emba… 

    …rgoed and not dataset

I had to duplicate initiation from zarr_dandiset fixture, but seems
overall a small price to pay.  Subsequent commit would refactor to make sweeping
embargoed status on new_dataset easier.
    @yarikoptic
    yarikoptic committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    c56665c View commit details
    Browse the repository at this point in the history

  2. RF: make any "new_dandiset" fixture work together with @sweep_embargo

    @yarikoptic
    yarikoptic committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    1deba35 View commit details
    Browse the repository at this point in the history

  3. ENH: Mark one more dataset testing on simpler files on embargo"ed ver… 

    …sion sync
    @yarikoptic
    yarikoptic committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    60ccca2 View commit details
    Browse the repository at this point in the history

  4. Add type annotation for mocker 

    Co-authored-by: John T. Wodder II <[email protected]>
    @yarikoptic @jwodder
    yarikoptic and jwodder committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    2a1c5ed View commit details
    Browse the repository at this point in the history