-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#399 #416 Initial fix for header/footer showing on page without body rows #418
base: open-dev-v1
Are you sure you want to change the base?
Conversation
…y rows. With test proof.
+ Remove unneeded casts. + Add override annotations. + Change anonymous class creation to lambda (manual).
Plus orphaned thead. Also compiler fixes for ContentLimit/ContentLimitContainer. Test based on the one provided by @jesselong. Thanks.
The test I just committed for #202 still produces this: so clearly there is still more related problems in the table code. |
Need more testing before we can merge this branch. Specifically: Cells with margin/border/padding. Cells which go over two or more pages.
Partial revert of dce1cd5 to get paged table with cells with large padding/border rendering correctly. Unfortunately, this means that the #202 test with explicitly allowing page breaks in thead now fails again. Fortunately, very few users want a page break in their thead so this is low priority to fix.
@danfickle Hi, any update when this will be ready to be released? I'm hopeful it will fix the issues i'm experiencing. |
@VictorAtPL, it is not clear from your comment if this is a problem introduced in this pr or was already existing? If it was already existing I propose to merge this pr and do a release, then we can work more on table rendering in a different pr. @leedsalex Very soon if this pr has not introduced any additional problems as above. |
@danfickle |
@danfickle v. 1.0.1: fix_399_empty_table_header_footer my dirty fix, from https://github.com/VictorAtPL/openhtmltopdf/tree/fix_thead_tfoot_without_content_bug Conclusions: |
Hi @VictorAtPL, |
I also plan to add some commits to this PR with general table cleanup of code.
@VictorAtPL, if you get time, you could perhaps test this branch with your real world tables.