fix push device registration #4297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
don't try to register a push device when the device is new it will be registered when the push token is saved fixes dani-garcia#4296
BlackDex
approved these changes
Jan 31, 2024
dani-garcia
approved these changes
Jan 31, 2024
dannybouwers
pushed a commit
to dannybouwers/homecontroller
that referenced
this pull request
Feb 22, 2024
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [vaultwarden/server](https://github.com/dani-garcia/vaultwarden) | patch | `1.30.2` -> `1.30.3` | --- ### Release Notes <details> <summary>dani-garcia/vaultwarden (vaultwarden/server)</summary> ### [`v1.30.3`](https://github.com/dani-garcia/vaultwarden/releases/tag/1.30.3) [Compare Source](dani-garcia/vaultwarden@1.30.2...1.30.3) This is a minor release to fix some issues with push notification device registration and docker healthcheck.⚠️ **Note:** The WebSockets service for live sync has been integrated in the main HTTP server, which means simpler proxy setups that don't require a separate rule to redirect WS traffic to port 3012. Please check the updated examples in the [wiki](https://github.com/dani-garcia/vaultwarden/wiki/Proxy-examples). It's recommended to migrate to this new setup as using the old server on port 3012 is deprecated, won't receive new features and will be removed in the next release. #### What's Changed - fix push device registration by [@​stefan0xC](https://github.com/stefan0xC) in dani-garcia/vaultwarden#4297 - Fix healthcheck when using .env file by [@​BlackDex](https://github.com/BlackDex) in dani-garcia/vaultwarden#4299 **Full Changelog**: dani-garcia/vaultwarden@1.30.2...1.30.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or rename PR to start with "rebase!". 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
arthurgeek
referenced
this pull request
in arthurgeek/vaultwarden-fly-template
Mar 18, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [vaultwarden/server](https://togithub.com/dani-garcia/vaultwarden) | stage | patch | `1.30.1-alpine` -> `1.30.5-alpine` | --- ### Release Notes <details> <summary>dani-garcia/vaultwarden (vaultwarden/server)</summary> ### [`v1.30.5`](https://togithub.com/dani-garcia/vaultwarden/releases/tag/1.30.5) [Compare Source](https://togithub.com/dani-garcia/vaultwarden/compare/1.30.4...1.30.5) #### What's Changed - fix: web API call for jquery 3.7.1 by [@​calvin-li-developer](https://togithub.com/calvin-li-developer) in [https://github.com/dani-garcia/vaultwarden/pull/4400](https://togithub.com/dani-garcia/vaultwarden/pull/4400) #### New Contributors - [@​calvin-li-developer](https://togithub.com/calvin-li-developer) made their first contribution in [https://github.com/dani-garcia/vaultwarden/pull/4400](https://togithub.com/dani-garcia/vaultwarden/pull/4400) **Full Changelog**: dani-garcia/vaultwarden@1.30.4...1.30.5 ### [`v1.30.4`](https://togithub.com/dani-garcia/vaultwarden/releases/tag/1.30.4) [Compare Source](https://togithub.com/dani-garcia/vaultwarden/compare/1.30.3...1.30.4)⚠️ Note: The WebSockets service for live sync has been integrated in the main HTTP server, which means simpler proxy setups that don't require a separate rule to redirect WS traffic to port 3012. Please check the updated examples in the [wiki](https://togithub.com/dani-garcia/vaultwarden/wiki/Proxy-examples). It's recommended to migrate to this new setup as using the old server on port 3012 is deprecated, won't receive new features and will be removed in the next release. #### What's Changed - Update crates to fix new builds by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4308](https://togithub.com/dani-garcia/vaultwarden/pull/4308) - Add Kubernetes environment detection by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4290](https://togithub.com/dani-garcia/vaultwarden/pull/4290) - Update GHA Workflows by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4309](https://togithub.com/dani-garcia/vaultwarden/pull/4309) - Update Rust, crates and web-vault by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4328](https://togithub.com/dani-garcia/vaultwarden/pull/4328) - Change the codegen-units for low resources by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4336](https://togithub.com/dani-garcia/vaultwarden/pull/4336) - Fix env templateto ensure compatibility with systemd's EnvironmentFile parsing by [@​seiuneko](https://togithub.com/seiuneko) in [https://github.com/dani-garcia/vaultwarden/pull/4315](https://togithub.com/dani-garcia/vaultwarden/pull/4315) - Update crates, GHA and a Python script by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4357](https://togithub.com/dani-garcia/vaultwarden/pull/4357) #### New Contributors - [@​seiuneko](https://togithub.com/seiuneko) made their first contribution in [https://github.com/dani-garcia/vaultwarden/pull/4315](https://togithub.com/dani-garcia/vaultwarden/pull/4315) **Full Changelog**: dani-garcia/vaultwarden@1.30.3...1.30.4 ### [`v1.30.3`](https://togithub.com/dani-garcia/vaultwarden/releases/tag/1.30.3) [Compare Source](https://togithub.com/dani-garcia/vaultwarden/compare/1.30.2...1.30.3) This is a minor release to fix some issues with push notification device registration and docker healthcheck.⚠️ **Note:** The WebSockets service for live sync has been integrated in the main HTTP server, which means simpler proxy setups that don't require a separate rule to redirect WS traffic to port 3012. Please check the updated examples in the [wiki](https://togithub.com/dani-garcia/vaultwarden/wiki/Proxy-examples). It's recommended to migrate to this new setup as using the old server on port 3012 is deprecated, won't receive new features and will be removed in the next release. #### What's Changed - fix push device registration by [@​stefan0xC](https://togithub.com/stefan0xC) in [https://github.com/dani-garcia/vaultwarden/pull/4297](https://togithub.com/dani-garcia/vaultwarden/pull/4297) - Fix healthcheck when using .env file by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4299](https://togithub.com/dani-garcia/vaultwarden/pull/4299) **Full Changelog**: dani-garcia/vaultwarden@1.30.2...1.30.3 ### [`v1.30.2`](https://togithub.com/dani-garcia/vaultwarden/releases/tag/1.30.2) [Compare Source](https://togithub.com/dani-garcia/vaultwarden/compare/1.30.1...1.30.2)⚠️ **Note:** The WebSockets service for live sync has been integrated in the main HTTP server, which means simpler proxy setups that don't require a separate rule to redirect WS traffic to port 3012. Please check the updated examples in the [wiki](https://togithub.com/dani-garcia/vaultwarden/wiki/Proxy-examples). It's recommended to migrate to this new setup as using the old server on port 3012 is deprecated, won't receive new features and will be removed in the next release. #### What's Changed - Prevent generating an error during ws close by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4127](https://togithub.com/dani-garcia/vaultwarden/pull/4127) - Update Rust, Crates, Profile and Actions by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4126](https://togithub.com/dani-garcia/vaultwarden/pull/4126) - Several small fixes for open issues by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4143](https://togithub.com/dani-garcia/vaultwarden/pull/4143) - Fix the version string by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4153](https://togithub.com/dani-garcia/vaultwarden/pull/4153) - Decrease JWT Refresh/Auth token by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4163](https://togithub.com/dani-garcia/vaultwarden/pull/4163) - Update crates by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4173](https://togithub.com/dani-garcia/vaultwarden/pull/4173) - Add additional build target which optimizes for size by [@​gladiac](https://togithub.com/gladiac) in [https://github.com/dani-garcia/vaultwarden/pull/4096](https://togithub.com/dani-garcia/vaultwarden/pull/4096) - Update web-vault to v2023.12.0 by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4201](https://togithub.com/dani-garcia/vaultwarden/pull/4201) - Update Rust and Crates by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4211](https://togithub.com/dani-garcia/vaultwarden/pull/4211) - Fix Single Org Policy check by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4207](https://togithub.com/dani-garcia/vaultwarden/pull/4207) - Allow customizing the featureStates by [@​PKizzle](https://togithub.com/PKizzle) in [https://github.com/dani-garcia/vaultwarden/pull/4168](https://togithub.com/dani-garcia/vaultwarden/pull/4168) - Fix [#​3413](https://togithub.com/dani-garcia/vaultwarden/issues/3413): push to users accessing the collections using groups by [@​matlink](https://togithub.com/matlink) in [https://github.com/dani-garcia/vaultwarden/pull/3757](https://togithub.com/dani-garcia/vaultwarden/pull/3757) - US or EU Data Region Selection by [@​toto-xoxo](https://togithub.com/toto-xoxo) in [https://github.com/dani-garcia/vaultwarden/pull/3752](https://togithub.com/dani-garcia/vaultwarden/pull/3752) - enforce 2FA policy on removal of second factor and login by [@​stefan0xC](https://togithub.com/stefan0xC) in [https://github.com/dani-garcia/vaultwarden/pull/3803](https://togithub.com/dani-garcia/vaultwarden/pull/3803) - improve emergency access when not enabled by [@​stefan0xC](https://togithub.com/stefan0xC) in [https://github.com/dani-garcia/vaultwarden/pull/4227](https://togithub.com/dani-garcia/vaultwarden/pull/4227) - Update crates and fix icon issue by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4237](https://togithub.com/dani-garcia/vaultwarden/pull/4237) - Bump h2 from 0.3.23 to 0.3.24 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/dani-garcia/vaultwarden/pull/4260](https://togithub.com/dani-garcia/vaultwarden/pull/4260) - Fix bulk collection deletion by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4257](https://togithub.com/dani-garcia/vaultwarden/pull/4257) - fix: use black text for update badge (better contrast) by [@​tessus](https://togithub.com/tessus) in [https://github.com/dani-garcia/vaultwarden/pull/4245](https://togithub.com/dani-garcia/vaultwarden/pull/4245) - prevent side effects if groups are disabled by [@​stefan0xC](https://togithub.com/stefan0xC) in [https://github.com/dani-garcia/vaultwarden/pull/4265](https://togithub.com/dani-garcia/vaultwarden/pull/4265) - Update crates, web-vault to 2024.1.2 and GHA by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4275](https://togithub.com/dani-garcia/vaultwarden/pull/4275) - Return 404 when user public_key is empty by [@​Timshel](https://togithub.com/Timshel) in [https://github.com/dani-garcia/vaultwarden/pull/4271](https://togithub.com/dani-garcia/vaultwarden/pull/4271) - Improve file limit handling by [@​dani-garcia](https://togithub.com/dani-garcia) in [https://github.com/dani-garcia/vaultwarden/pull/4242](https://togithub.com/dani-garcia/vaultwarden/pull/4242) - Fix attachment upload size check by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4282](https://togithub.com/dani-garcia/vaultwarden/pull/4282) - err on invalid feature flag by [@​stefan0xC](https://togithub.com/stefan0xC) in [https://github.com/dani-garcia/vaultwarden/pull/4263](https://togithub.com/dani-garcia/vaultwarden/pull/4263) - register missing push devices at login by [@​stefan0xC](https://togithub.com/stefan0xC) in [https://github.com/dani-garcia/vaultwarden/pull/3792](https://togithub.com/dani-garcia/vaultwarden/pull/3792) - Update env template file by [@​gzfrozen](https://togithub.com/gzfrozen) in [https://github.com/dani-garcia/vaultwarden/pull/4276](https://togithub.com/dani-garcia/vaultwarden/pull/4276) #### New Contributors - [@​gladiac](https://togithub.com/gladiac) made their first contribution in [https://github.com/dani-garcia/vaultwarden/pull/4096](https://togithub.com/dani-garcia/vaultwarden/pull/4096) - [@​PKizzle](https://togithub.com/PKizzle) made their first contribution in [https://github.com/dani-garcia/vaultwarden/pull/4168](https://togithub.com/dani-garcia/vaultwarden/pull/4168) - [@​matlink](https://togithub.com/matlink) made their first contribution in [https://github.com/dani-garcia/vaultwarden/pull/3757](https://togithub.com/dani-garcia/vaultwarden/pull/3757) - [@​toto-xoxo](https://togithub.com/toto-xoxo) made their first contribution in [https://github.com/dani-garcia/vaultwarden/pull/3752](https://togithub.com/dani-garcia/vaultwarden/pull/3752) - [@​Timshel](https://togithub.com/Timshel) made their first contribution in [https://github.com/dani-garcia/vaultwarden/pull/4271](https://togithub.com/dani-garcia/vaultwarden/pull/4271) - [@​gzfrozen](https://togithub.com/gzfrozen) made their first contribution in [https://github.com/dani-garcia/vaultwarden/pull/4276](https://togithub.com/dani-garcia/vaultwarden/pull/4276) **Full Changelog**: dani-garcia/vaultwarden@1.30.1...1.30.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on saturday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/arthurgeek/vaultwarden-fly-template). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNTMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjIyMC4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't try to register a push device when the device is new
It will be registered when the push token is saved
fixes #4296